Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(316)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1120143002: Move state management to GrInOrderDrawBuffer (Closed)

Created:
5 years, 7 months ago by joshua.litt
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@batchownsbounds
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : tweak #

Total comments: 1

Patch Set 3 : windows warning #

Patch Set 4 : windows warning take 2 #

Patch Set 5 : tidying #

Patch Set 6 : a bit more #

Unified diffs Side-by-side diffs Delta from patch set Stats (+229 lines, -245 lines) Patch
M src/gpu/GrAtlasTextContext.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.h View 3 chunks +23 lines, -1 line 0 comments Download
M src/gpu/GrInOrderDrawBuffer.cpp View 1 2 3 4 9 chunks +82 lines, -11 lines 0 comments Download
M src/gpu/GrTargetCommands.h View 1 2 3 4 5 13 chunks +80 lines, -82 lines 0 comments Download
M src/gpu/GrTargetCommands.cpp View 17 chunks +44 lines, -150 lines 0 comments Download

Messages

Total messages: 21 (10 generated)
joshualitt
ptal https://codereview.chromium.org/1120143002/diff/20001/src/gpu/GrInOrderDrawBuffer.h File src/gpu/GrInOrderDrawBuffer.h (right): https://codereview.chromium.org/1120143002/diff/20001/src/gpu/GrInOrderDrawBuffer.h#newcode144 src/gpu/GrInOrderDrawBuffer.h:144: kPipelineBufferMinReserve = 32 * sizeof(State), Not sure what ...
5 years, 7 months ago (2015-05-01 19:55:02 UTC) #2
robertphillips
lgtm but I would like Brian's opinion too.
5 years, 7 months ago (2015-05-04 12:37:59 UTC) #3
bsalomon
seems ok to me but seems like we have a lot of GrDrawState legacy naming ...
5 years, 7 months ago (2015-05-04 14:01:48 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120143002/20001
5 years, 7 months ago (2015-05-04 14:27:11 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-MSVC-x86-Debug-Trybot on client.skia.compile (JOB_FAILED, http://build.chromium.org/p/client.skia.compile/builders/Build-Win-MSVC-x86-Debug-Trybot/builds/822)
5 years, 7 months ago (2015-05-04 14:30:33 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120143002/60001
5 years, 7 months ago (2015-05-04 14:38:34 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/5d6bb6f795143ca360b868560b52165de51fa269
5 years, 7 months ago (2015-05-04 14:41:48 UTC) #12
joshualitt
A revert of this CL (patchset #4 id:60001) has been created in https://codereview.chromium.org/1119353002/ by joshualitt@google.com. ...
5 years, 7 months ago (2015-05-04 14:50:42 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120143002/80001
5 years, 7 months ago (2015-05-04 15:49:34 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120143002/100001
5 years, 7 months ago (2015-05-04 15:59:54 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 17:42:03 UTC) #21
Message was sent while issue was closed. 
Committed patchset #6 (id:100001) as
https://skia.googlesource.com/skia/+/0911430dfb812a9341740bfabf1c86d14fb25af4

Powered by Google App Engine
This is Rietveld 408576698