Source/core/css/CSSPrimitiveValue.cpp - Issue 1120133004: Serialize <number> to round to at most 6 decimals

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/CSSPrimitiveValue.cpp

Issue 1120133004: Serialize <number> to round to at most 6 decimals (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« LayoutTests/imported/csswg-test/css-shapes-1/shape-outside/values/shape-margin-002.html ('K') | « LayoutTests/transforms/transform-inherit-initial-unprefixed-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/css/CSSPrimitiveValue.cpp

diff --git a/Source/core/css/CSSPrimitiveValue.cpp b/Source/core/css/CSSPrimitiveValue.cpp

index 2af60a8a5f8d9644070f566a028caf276d81115c..b6a57c86e4c75dd7414479a061c0f824a200856f 100644

--- a/Source/core/css/CSSPrimitiveValue.cpp

+++ b/Source/core/css/CSSPrimitiveValue.cpp

@@ -32,7 +32,6 @@

#include "core/css/StyleSheetContents.h"

#include "core/dom/Node.h"

#include "core/style/ComputedStyle.h"

-#include "platform/Decimal.h"

#include "platform/LayoutUnit.h"

#include "platform/fonts/FontMetrics.h"

#include "wtf/StdLibExtras.h"

@@ -830,8 +829,7 @@ String CSSPrimitiveValue::getStringValue() const

static String formatNumber(double number, const char* suffix, unsigned suffixLength)

{

- Decimal decimal = Decimal::fromDouble(number);

- String result = decimal.toString();

+ String result = String::format("%.6g", number);

result.append(suffix, suffixLength);

return result;

}