runtime/observatory/tests/service/test_helper.dart - Issue 1120133002: Rework error handling in the service protocol and in Observatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/tests/service/test_helper.dart

Issue 1120133002: Rework error handling in the service protocol and in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: fix tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: runtime/observatory/tests/service/test_helper.dart

diff --git a/runtime/observatory/tests/service/test_helper.dart b/runtime/observatory/tests/service/test_helper.dart

index fd639339c41e9fc74aa99ab03685e4c671d309bd..6da69becfc01f52b5f273e55768acc87ae72a345 100644

--- a/runtime/observatory/tests/service/test_helper.dart

+++ b/runtime/observatory/tests/service/test_helper.dart

@@ -11,10 +11,7 @@ import 'dart:io';

import 'package:observatory/service_io.dart';

bool _isWebSocketDisconnect(e) {

- if (e is! ServiceException) {

- return false;

- }

- return (e as ServiceException).message == 'WebSocket closed';

+ return e is NetworkRpcException;

}

// This invocation should set up the state being tested.

« no previous file with comments | « runtime/observatory/tests/service/native_metrics_test.dart ('k') | runtime/vm/json_stream.h » ('j') | no next file with comments »