Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Unified Diff: runtime/observatory/tests/service/bad_web_socket_address_test.dart

Issue 1120133002: Rework error handling in the service protocol and in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/tests/service/bad_web_socket_address_test.dart
diff --git a/runtime/observatory/tests/service/bad_web_socket_address_test.dart b/runtime/observatory/tests/service/bad_web_socket_address_test.dart
index fd259b444911e550b9303485722069db33d9a289..d32831204c4aa5e0f2e37470f7037ff6653d5c4f 100644
--- a/runtime/observatory/tests/service/bad_web_socket_address_test.dart
+++ b/runtime/observatory/tests/service/bad_web_socket_address_test.dart
@@ -3,17 +3,23 @@
// BSD-style license that can be found in the LICENSE file.
// VMOptions=--compile-all --error_on_bad_type --error_on_bad_override
+import 'package:logging/logging.dart';
import "package:observatory/service_io.dart";
import 'package:unittest/unittest.dart';
void testBadWebSocket() {
var vm = new WebSocketVM(new WebSocketVMTarget('ws://karatekid/ws'));
vm.load().catchError(expectAsync((error) {
- expect(error is ServiceException, isTrue);
- }));
+ expect(error, new isInstanceOf<NetworkRpcException>());
+ }));
}
main() {
+ Logger.root.level = Level.INFO;
+ Logger.root.onRecord.listen((LogRecord rec) {
+ print('${rec.level.name}: ${rec.time}: ${rec.message}');
+ });
+
test('bad web socket address', testBadWebSocket);
}
« no previous file with comments | « runtime/observatory/observatory_sources.gypi ('k') | runtime/observatory/tests/service/get_allocation_profile_rpc_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698