runtime/observatory/lib/src/elements/service_view.dart - Issue 1120133002: Rework error handling in the service protocol and in Observatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/service_view.dart

Issue 1120133002: Rework error handling in the service protocol and in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: fix tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/lib/src/elements/service_exception_view.html ('k') | runtime/observatory/lib/src/elements/vm_connect.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/lib/src/elements/service_view.dart

diff --git a/runtime/observatory/lib/src/elements/service_view.dart b/runtime/observatory/lib/src/elements/service_view.dart

index 547b8fce17f88741863808e3c4ae7e40f5ef0469..afedd621ab3462408385db69ff4ad30ad001473d 100644

--- a/runtime/observatory/lib/src/elements/service_view.dart

+++ b/runtime/observatory/lib/src/elements/service_view.dart

@@ -126,16 +126,6 @@ class ServiceObjectViewElement extends ObservatoryElement {

new Element.tag('io-random-access-file-view');

element.file = object;

return element;

- case 'ServiceError':

- ServiceErrorViewElement element =

- new Element.tag('service-error-view');

- element.error = object;

- return element;

- case 'ServiceException':

- ServiceExceptionViewElement element =

- new Element.tag('service-exception-view');

- element.exception = object;

- return element;

case 'Script':

ScriptViewElement element = new Element.tag('script-view');

element.script = object;