runtime/observatory/lib/src/elements/script_view.dart - Issue 1120133002: Rework error handling in the service protocol and in Observatory.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/observatory/lib/src/elements/script_view.dart

Issue 1120133002: Rework error handling in the service protocol and in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: fix tests Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « runtime/observatory/lib/src/elements/script_inset.dart ('k') | runtime/observatory/lib/src/elements/service_error_view.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: runtime/observatory/lib/src/elements/script_view.dart

diff --git a/runtime/observatory/lib/src/elements/script_view.dart b/runtime/observatory/lib/src/elements/script_view.dart

index fa8ccd291f865f4912f5ed09a75a6b2efb34884a..ff07a808461f05cbf1c6613a21b6bfcce089e676 100644

--- a/runtime/observatory/lib/src/elements/script_view.dart

+++ b/runtime/observatory/lib/src/elements/script_view.dart

@@ -4,6 +4,7 @@

library script_view_element;

+import 'dart:async';

import 'observatory_element.dart';

import 'package:observatory/elements.dart';

import 'package:observatory/service.dart';

@@ -16,11 +17,11 @@ class ScriptViewElement extends ObservatoryElement {

ScriptViewElement.created() : super.created();

- void refresh(var done) {

- script.reload().whenComplete(done);

+ Future refresh() {

+ return script.reload();

}

- void refreshCoverage(var done) {

- script.refreshCoverage().whenComplete(done);

+ Future refreshCoverage() {

+ return script.refreshCoverage();

}