Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Unified Diff: runtime/observatory/lib/src/elements/object_common.dart

Issue 1120133002: Rework error handling in the service protocol and in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/object_common.dart
diff --git a/runtime/observatory/lib/src/elements/object_common.dart b/runtime/observatory/lib/src/elements/object_common.dart
index 929ebd6f4200a7b25c04d00ffd0fce55e0d017cd..eea85ffcaf0e5f040952c2ba8f7443185f658f27 100644
--- a/runtime/observatory/lib/src/elements/object_common.dart
+++ b/runtime/observatory/lib/src/elements/object_common.dart
@@ -21,6 +21,7 @@ class ObjectCommonElement extends ObservatoryElement {
// TODO(koda): Add no-arg "calculate-link" instead of reusing "eval-link".
Future<ServiceObject> retainedSize(var dummy) {
return object.isolate.getRetainedSize(object).then((Instance obj) {
+ // TODO(turnidge): Handle collected/expired objects gracefully.
retainedBytes = int.parse(obj.valueAsString);
});
}
@@ -38,7 +39,7 @@ class ObjectCommonElement extends ObservatoryElement {
});
}
- void refresh(Function onDone) {
- object.reload().whenComplete(onDone);
+ Future refresh() {
+ return object.reload();
}
}
« no previous file with comments | « runtime/observatory/lib/src/elements/nav_bar.html ('k') | runtime/observatory/lib/src/elements/object_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698