Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Unified Diff: runtime/observatory/lib/src/elements/cpu_profile.html

Issue 1120133002: Rework error handling in the service protocol and in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/cpu_profile.html
diff --git a/runtime/observatory/lib/src/elements/cpu_profile.html b/runtime/observatory/lib/src/elements/cpu_profile.html
index ab271273ae607f2c81e494c9f5751e20ac654105..685ad868a2a7d288080ecc4063780edf2736d67c 100644
--- a/runtime/observatory/lib/src/elements/cpu_profile.html
+++ b/runtime/observatory/lib/src/elements/cpu_profile.html
@@ -15,7 +15,7 @@
<isolate-nav-menu isolate="{{ isolate }}"></isolate-nav-menu>
<nav-menu link="{{ makeLink('/profiler-table', isolate) }}" anchor="cpu profile (table)" last="{{ true }}"></nav-menu>
<nav-refresh callback="{{ refresh }}"></nav-refresh>
- <nav-refresh callback="{{ clear }}" label="Clear"></nav-refresh>
+ <nav-refresh callback="{{ clearCpuProfile }}" label="Clear"></nav-refresh>
</nav-bar>
<style>
/* general */
@@ -150,10 +150,22 @@
<div class="statusMessage">Loading profile...</div>
</div>
</template>
+ <template if="{{ state == 'Disabled' }}">
+ <div class="statusBox shadow center">
+ <div>
+ <h1>Profiling is disabled</h1>
+ <br>
+ Perhaps the <b>profile</b> flag has been disabled for this VM.
+ <br><br>
+ See all
+ <a on-click="{{ goto }}" _href="{{ gotoLink('/flags') }}">vm flags</a>
+ </div>
+ </div>
+ </template>
<template if="{{ state == 'Exception' }}">
<div class="statusBox shadow center">
<div class="statusMessage">
- <h1>Exception:</h1>
+ <h1>Profiling is disabled due to unexpected exception:</h1>
<br>
<pre>{{ exception.toString() }}</pre>
<br>
@@ -281,7 +293,7 @@
<isolate-nav-menu isolate="{{ isolate }}"></isolate-nav-menu>
<nav-menu link="{{ makeLink('/profiler', isolate) }}" anchor="cpu profile" last="{{ true }}"></nav-menu>
<nav-refresh callback="{{ refresh }}"></nav-refresh>
- <nav-refresh callback="{{ clear }}" label="Clear"></nav-refresh>
+ <nav-refresh callback="{{ clearCpuProfile }}" label="Clear"></nav-refresh>
</nav-bar>
<style>
.tableWell {
@@ -372,10 +384,22 @@
<div class="statusMessage">Loading profile...</div>
</div>
</template>
+ <template if="{{ state == 'Disabled' }}">
+ <div class="statusBox shadow center">
+ <div>
+ <h1>Profiling is disabled</h1>
+ <br>
+ Perhaps the <b>profile</b> flag has been disabled for this VM.
+ <br><br>
+ See all
+ <a on-click="{{ goto }}" _href="{{ gotoLink('/flags') }}">vm flags</a>
+ </div>
+ </div>
+ </template>
<template if="{{ state == 'Exception' }}">
<div class="statusBox shadow center">
<div class="statusMessage">
- <h1>Exception:</h1>
+ <h1>Profiling is disabled due to unexpected exception:</h1>
<br>
<pre>{{ exception.toString() }}</pre>
<br>
« no previous file with comments | « runtime/observatory/lib/src/elements/cpu_profile.dart ('k') | runtime/observatory/lib/src/elements/css/shared.css » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698