Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(248)

Unified Diff: runtime/observatory/lib/src/elements/code_view.dart

Issue 1120133002: Rework error handling in the service protocol and in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: runtime/observatory/lib/src/elements/code_view.dart
diff --git a/runtime/observatory/lib/src/elements/code_view.dart b/runtime/observatory/lib/src/elements/code_view.dart
index f6ba19499150af0fb9fe9c1cf6ca2657003cb4c7..868886f2091f7a1a6edf1bc65428e7e0e8dfb93c 100644
--- a/runtime/observatory/lib/src/elements/code_view.dart
+++ b/runtime/observatory/lib/src/elements/code_view.dart
@@ -4,6 +4,7 @@
library code_view_element;
+import 'dart:async';
import 'dart:html';
import 'observatory_element.dart';
import 'package:observatory/app.dart';
@@ -60,19 +61,19 @@ class CodeViewElement extends ObservatoryElement {
});
}
- void refresh(var done) {
- code.reload().whenComplete(done);
+ Future refresh() {
+ return code.reload();
}
- void refreshTicks(var done) {
+ Future refreshTicks() {
var isolate = code.isolate;
- isolate.invokeRpc('getCpuProfile', { 'tags': 'None' })
- .then((ServiceMap response) {
- var cpuProfile = new CpuProfile();
- cpuProfile.load(isolate, response);
- _updateDisassembly();
- _updateInline();
- }).whenComplete(done);
+ return isolate.invokeRpc('getCpuProfile', { 'tags': 'None' })
+ .then((ServiceMap response) {
+ var cpuProfile = new CpuProfile();
+ cpuProfile.load(isolate, response);
+ _updateDisassembly();
+ _updateInline();
+ });
}
String formattedAddress(CodeInstruction instruction) {
« no previous file with comments | « runtime/observatory/lib/src/elements/class_view.dart ('k') | runtime/observatory/lib/src/elements/context_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698