Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1426)

Side by Side Diff: runtime/observatory/lib/src/elements/instance_view.dart

Issue 1120133002: Rework error handling in the service protocol and in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: fix tests Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 4
5 library instance_view_element; 5 library instance_view_element;
6 6
7 import 'dart:async'; 7 import 'dart:async';
8 import 'observatory_element.dart'; 8 import 'observatory_element.dart';
9 import 'package:observatory/service.dart'; 9 import 'package:observatory/service.dart';
10 import 'package:polymer/polymer.dart'; 10 import 'package:polymer/polymer.dart';
11 11
12 @CustomTag('instance-view') 12 @CustomTag('instance-view')
13 class InstanceViewElement extends ObservatoryElement { 13 class InstanceViewElement extends ObservatoryElement {
14 @published Instance instance; 14 @published Instance instance;
15 15
16 InstanceViewElement.created() : super.created(); 16 InstanceViewElement.created() : super.created();
17 17
18 Future<ServiceObject> eval(String expression) { 18 Future<ServiceObject> eval(String expression) {
19 return instance.isolate.eval(instance, expression); 19 return instance.isolate.eval(instance, expression);
20 } 20 }
21 21
22 void refresh(Function onDone) { 22 Future refresh() {
23 instance.reload().whenComplete(onDone); 23 return instance.reload();
24 } 24 }
25 } 25 }
OLDNEW
« no previous file with comments | « runtime/observatory/lib/src/elements/instance_ref.html ('k') | runtime/observatory/lib/src/elements/io_view.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698