Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Side by Side Diff: runtime/observatory/tests/service/test_helper.dart

Issue 1120133002: Rework error handling in the service protocol and in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2013, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--compile-all --error_on_bad_type --error_on_bad_override --checked 4 // VMOptions=--compile-all --error_on_bad_type --error_on_bad_override --checked
5 5
6 library test_helper; 6 library test_helper;
7 7
8 import 'dart:async'; 8 import 'dart:async';
9 import 'dart:convert'; 9 import 'dart:convert';
10 import 'dart:io'; 10 import 'dart:io';
11 import 'package:observatory/service_io.dart'; 11 import 'package:observatory/service_io.dart';
12 12
13 bool _isWebSocketDisconnect(e) { 13 bool _isWebSocketDisconnect(e) {
14 if (e is! ServiceException) { 14 return e is NetworkRpcException;
15 return false;
16 }
17 return (e as ServiceException).message == 'WebSocket closed';
18 } 15 }
19 16
20 // This invocation should set up the state being tested. 17 // This invocation should set up the state being tested.
21 const String _TESTEE_MODE_FLAG = "--testee-mode"; 18 const String _TESTEE_MODE_FLAG = "--testee-mode";
22 19
23 class _TestLauncher { 20 class _TestLauncher {
24 Process process; 21 Process process;
25 final List<String> args; 22 final List<String> args;
26 bool killedByTester = false; 23 bool killedByTester = false;
27 24
(...skipping 181 matching lines...) Expand 10 before | Expand all | Expand 10 after
209 }, onError: (e, st) { 206 }, onError: (e, st) {
210 process.requestExit(); 207 process.requestExit();
211 if (!_isWebSocketDisconnect(e)) { 208 if (!_isWebSocketDisconnect(e)) {
212 print('Unexpected exception in service tests: $e $st'); 209 print('Unexpected exception in service tests: $e $st');
213 throw e; 210 throw e;
214 } 211 }
215 }); 212 });
216 }); 213 });
217 } 214 }
218 } 215 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698