Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(826)

Side by Side Diff: runtime/observatory/tests/service/bad_web_socket_address_test.dart

Issue 1120133002: Rework error handling in the service protocol and in Observatory. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file 1 // Copyright (c) 2014, the Dart project authors. Please see the AUTHORS file
2 // for details. All rights reserved. Use of this source code is governed by a 2 // for details. All rights reserved. Use of this source code is governed by a
3 // BSD-style license that can be found in the LICENSE file. 3 // BSD-style license that can be found in the LICENSE file.
4 // VMOptions=--compile-all --error_on_bad_type --error_on_bad_override 4 // VMOptions=--compile-all --error_on_bad_type --error_on_bad_override
5 5
6 import 'package:logging/logging.dart';
6 import "package:observatory/service_io.dart"; 7 import "package:observatory/service_io.dart";
7 import 'package:unittest/unittest.dart'; 8 import 'package:unittest/unittest.dart';
8 9
9 void testBadWebSocket() { 10 void testBadWebSocket() {
10 var vm = new WebSocketVM(new WebSocketVMTarget('ws://karatekid/ws')); 11 var vm = new WebSocketVM(new WebSocketVMTarget('ws://karatekid/ws'));
11 vm.load().catchError(expectAsync((error) { 12 vm.load().catchError(expectAsync((error) {
12 expect(error is ServiceException, isTrue); 13 expect(error, new isInstanceOf<NetworkRpcException>());
13 })); 14 }));
14 } 15 }
15 16
16 main() { 17 main() {
18 Logger.root.level = Level.INFO;
19 Logger.root.onRecord.listen((LogRecord rec) {
Cutch 2015/05/13 17:50:09 Should this log setup code be inside test_helper?
turnidge 2015/05/14 17:53:43 This test doesn't use test_helper.
20 print('${rec.level.name}: ${rec.time}: ${rec.message}');
21 });
22
17 test('bad web socket address', testBadWebSocket); 23 test('bad web socket address', testBadWebSocket);
18 } 24 }
19 25
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698