Rework error handling in the service protocol and in Observatory.

runtime/observatory/lib/src/elements/nav_bar.dart

 // Copyright (c) 2013, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library nav_bar_element;
 
 import 'dart:async';
 import 'dart:html';
 import 'observatory_element.dart';
 import 'package:observatory/service.dart';
 import 'package:polymer/polymer.dart';
 
 
 @CustomTag('nav-bar')
 class NavBarElement extends ObservatoryElement {
-  @published bool showNotify = true;
+  @published bool notifyOnPause = true;
   @published bool pad = true;
 
   NavBarElement.created() : super.created();
 }
 
 @CustomTag('nav-menu')
 class NavMenuElement extends ObservatoryElement {
   @published String link = '#';
   @published String anchor = '---';
   @published bool last = false;
 
   NavMenuElement.created() : super.created();
 }
 
 @CustomTag('nav-menu-item')
 class NavMenuItemElement extends ObservatoryElement {
   @published String link = '#';
   @published String anchor = '---';
 
   NavMenuItemElement.created() : super.created();
 }
 
+typedef Future RefreshCallback();
+
 @CustomTag('nav-refresh')
 class NavRefreshElement extends ObservatoryElement {
-  @published var callback;
+  @published RefreshCallback callback;
   @published bool active = false;
   @published String label = 'Refresh';
 
   NavRefreshElement.created() : super.created();
 
   void buttonClick(Event e, var detail, Node target) {
     if (active) {
       return;
     }
     active = true;
     if (callback != null) {
-      callback(refreshDone);
+      callback()
+        .catchError(app.handleException)
+        .whenComplete(refreshDone);
     }
   }
 
   void refreshDone() {
     active = false;
   }
 }
 
 @CustomTag('top-nav-menu')
 class TopNavMenuElement extends ObservatoryElement {
@@ skipping 29 matching lines @@
 @CustomTag('class-nav-menu')
 class ClassNavMenuElement extends ObservatoryElement {
   @published Class cls;
   @published bool last = false;
 
   ClassNavMenuElement.created() : super.created();
 }
 
 @CustomTag('nav-notify')
 class NavNotifyElement extends ObservatoryElement {
-  @published ObservableList<ServiceEvent> events;
+  @published ObservableList<Notification> notifications;
+  @published bool notifyOnPause = true;
 
   NavNotifyElement.created() : super.created();
 }
 
-@CustomTag('nav-notify-item')
-class NavNotifyItemElement extends ObservatoryElement {
-  @published ObservableList<ServiceEvent> events;
+@CustomTag('nav-notify-event')
+class NavNotifyEventElement extends ObservatoryElement {
+  @published ObservableList<Notification> notifications;
+  @published Notification notification;
   @published ServiceEvent event;
+  @published bool notifyOnPause = true;
 
-  Future resume(_) {
-    app.removePauseEvents(event.isolate);
-    return event.isolate.resume();
+  void closeItem(MouseEvent e, var detail, Element target) {
+    notifications.remove(notification);
   }
-  Future stepInto(_) {
-    app.removePauseEvents(event.isolate);
-    return event.isolate.stepInto();
+
+  NavNotifyEventElement.created() : super.created();
+}
+
+@CustomTag('nav-notify-exception')
+class NavNotifyExceptionElement extends ObservatoryElement {
+  @published ObservableList<Notification> notifications;
+  @published Notification notification;
+  @published var exception;
+  @published var stacktrace;
+
+  exceptionChanged() {
+    notifyPropertyChange(#isNetworkError, true, false);
+    notifyPropertyChange(#isUnexpectedError, true, false);
   }
-  Future stepOver(_) {
-    app.removePauseEvents(event.isolate);
-    return event.isolate.stepOver();
+
+  @observable get isNetworkError {
+    return (exception is NetworkRpcException);
   }
-  Future stepOut(_) {
-    app.removePauseEvents(event.isolate);
-    return event.isolate.stepOut();
+
+  @observable get isUnexpectedError {
+    return (exception is! NetworkRpcException);
   }
 
   void closeItem(MouseEvent e, var detail, Element target) {
-    events.remove(event);
+    notifications.remove(notification);
   }
 
-  NavNotifyItemElement.created() : super.created();
+  NavNotifyExceptionElement.created() : super.created();
 }