Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(234)

Issue 1120113002: fix file uri suggestions on Windows (Closed)

Created:
5 years, 7 months ago by danrubel
Modified:
5 years, 7 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/remotes/git-svn
Visibility:
Public.

Description

fix file uri suggestions on Windows BUG=dartbug.com/23073 R=scheglov@google.com Committed: https://code.google.com/p/dart/source/detail?r=45500

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+36 lines, -41 lines) Patch
M pkg/analysis_server/lib/src/services/completion/import_uri_contributor.dart View 3 chunks +7 lines, -4 lines 0 comments Download
M pkg/analysis_server/test/services/completion/import_uri_contributor_test.dart View 11 chunks +29 lines, -37 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 7 months ago (2015-05-01 16:29:25 UTC) #2
scheglov
LGTM
5 years, 7 months ago (2015-05-01 16:33:36 UTC) #3
danrubel
5 years, 7 months ago (2015-05-04 18:16:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as 45500 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698