Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(189)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1120093002: Only swap undefined for the global object if necessary in the prologue (Closed)

Created:
5 years, 7 months ago by Toon Verwaest
Modified:
5 years, 7 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Only swap undefined for the global object if necessary in the prologue BUG= Committed: https://crrev.com/fab3508062396c2768b5dcfa0fd7d40eba527d62 Cr-Commit-Position: refs/heads/master@{#28200}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : Remove flag #

Unified diffs Side-by-side diffs Delta from patch set Stats (+29 lines, -27 lines) Patch
M src/arm/full-codegen-arm.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm/lithium-codegen-arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/arm64/full-codegen-arm64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/arm64/lithium-codegen-arm64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/compiler.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler.cc View 1 chunk +6 lines, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/hydrogen.h View 1 2 2 chunks +0 lines, -4 lines 0 comments Download
M src/hydrogen.cc View 1 2 2 chunks +0 lines, -5 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/ia32/lithium-codegen-ia32.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips/full-codegen-mips.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips/lithium-codegen-mips.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/full-codegen-mips64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x64/full-codegen-x64.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x64/lithium-codegen-x64.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M src/x87/full-codegen-x87.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/x87/lithium-codegen-x87.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
Toon Verwaest
PTAL
5 years, 7 months ago (2015-05-04 09:32:59 UTC) #2
Igor Sheludko
lgtm
5 years, 7 months ago (2015-05-04 11:34:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120093002/40001
5 years, 7 months ago (2015-05-04 12:51:32 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-04 13:38:54 UTC) #6
commit-bot: I haz the power
5 years, 7 months ago (2015-05-04 13:39:16 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/fab3508062396c2768b5dcfa0fd7d40eba527d62
Cr-Commit-Position: refs/heads/master@{#28200}

Powered by Google App Engine
This is Rietveld 408576698