Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(845)

Unified Diff: build/common.gypi

Issue 1120083003: Introduce the support required to test a Kasko-enabled build on Swarm. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@enable_kasko_by_default
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: build/common.gypi
diff --git a/build/common.gypi b/build/common.gypi
index 7c927479548bf3815d4203c5676c2d09777850a4..41ce88a49f774f8b39572c79eda27b580a15e1a8 100644
--- a/build/common.gypi
+++ b/build/common.gypi
@@ -416,9 +416,6 @@
# See https://code.google.com/p/sawbuck/wiki/SyzyASanHowTo
'syzyasan%': 0,
- # Enable crash reporting via Kasko.
- 'kasko%': 0,
-
# Enable building with LSan (Clang's -fsanitize=leak option).
# -fsanitize=leak only works with clang, but lsan=1 implies clang=1
# See https://sites.google.com/a/chromium.org/dev/developers/testing/leaksanitizer
@@ -1011,6 +1008,14 @@
}, {
'sas_dll_path%': '<(DEPTH)/third_party/platformsdk_win7/files/redist/x86',
}],
+
+ # Enable crash reporting via Kasko.
+ ['OS=="win" and target_arch=="ia32"', {
+ 'kasko%': 0,
csharp 2015/05/01 20:08:12 Is this suppose to be the same value in both place
erikwright (departed) 2015/05/04 15:06:07 This doesn't need to be in the current CL.
+ }, {
+ 'kasko%': 0,
+ }],
+
],
# Setting this to '0' will cause V8's startup snapshot to be
« no previous file with comments | « build/android/pylib/utils/isolator.py ('k') | build/isolate.gypi » ('j') | chrome/chrome.isolate » ('J')

Powered by Google App Engine
This is Rietveld 408576698