Introduce the support required to test a Kasko-enabled build on Swarm.

Introduce the support required to test a Kasko-enabled build on Swarm.

BUG=478209
TBR=dpranke

Committed: https://crrev.com/55414130d4ce0ccf2105e3189acd77de926beeb7
Cr-Commit-Position: refs/heads/master@{#328185}

[erikwright (departed), 2015-05-01 19:09:19]

The CQ bit was checked by erikwright@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-01 19:09:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1120083003/1

[commit-bot: I haz the power, 2015-05-01 19:09:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-01 19:09:48]

Dry run: CLs for remote refs other than refs/pending/heads/master must contain
NOTRY=true and NOPRESUBMIT=true in order for the CQ to process them

[erikwright (departed), 2015-05-01 19:10:12]

erikwright@chromium.org changed reviewers:
+ csharp@chromium.org

[erikwright (departed), 2015-05-01 19:10:13]

csharp: PTAL.

I assume dpranke@ is a good choice for the build/ stamp?

[csharp, 2015-05-01 20:08:12]

csharp@chromium.org changed reviewers:
+ maruel@chromium.org

[csharp, 2015-05-01 20:08:12]

adding maruel@ since he can provider owner's approval for build change and he
know isolate stuff :)

https://codereview.chromium.org/1120083003/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1120083003/diff/1/build/common.gypi#newcode1014
build/common.gypi:1014: 'kasko%': 0,
Is this suppose to be the same value in both places?

[M-A Ruel, 2015-05-01 20:17:24]

https://codereview.chromium.org/1120083003/diff/1/chrome/chrome.isolate
File chrome/chrome.isolate (right):

https://codereview.chromium.org/1120083003/diff/1/chrome/chrome.isolate#newco...
chrome/chrome.isolate:126: ['kasko==1', {
I'd still prefer to gate it also on OS=="win", in case there's kasko of other
OSes one day and it also help describing the subset. Same for other isolate
files.

[erikwright (departed), 2015-05-04 15:06:07]

PTAL.

Also, it would be really convenient if you guys were owners for isolate.gypi and
isolator.py. WDYT? Otherwise, I assume dpranke@ and jbudorick@ are the
appropriate choices.

https://codereview.chromium.org/1120083003/diff/1/build/common.gypi
File build/common.gypi (right):

https://codereview.chromium.org/1120083003/diff/1/build/common.gypi#newcode1014
build/common.gypi:1014: 'kasko%': 0,
On 2015/05/01 20:08:12, csharp wrote:
> Is this suppose to be the same value in both places?

This doesn't need to be in the current CL.

[csharp, 2015-05-04 15:16:05]

I don't really touch the isolate file anymore (other than a few reviews), so I
don't think I should be owner of any more files related to it.

But with regards to this change, lgtm if you move the conditions a bit (as
explained in my comment)

https://codereview.chromium.org/1120083003/diff/20001/chrome/unit_tests.isolate
File chrome/unit_tests.isolate (right):

https://codereview.chromium.org/1120083003/diff/20001/chrome/unit_tests.isola...
chrome/unit_tests.isolate:156: ['OS=="win" and kasko==1', {
This should probably move up a bit to be with the other OS=win conditions
(instead of having the chromeos=1 condition in the middle). Same for the other
files where it is separated.

[erikwright (departed), 2015-05-04 15:24:41]

OK, maybe you should be taken out of chrome/OWNERS for the .isolate files.

maruel, what do you think about having one person capable of reviewing
isolate.gypi, *.isolate, and isolator.py?

[M-A Ruel, 2015-05-04 15:25:32]

On 2015/05/04 15:24:41, erikwright wrote:
> OK, maybe you should be taken out of chrome/OWNERS for the .isolate files.
> 
> maruel, what do you think about having one person capable of reviewing
> isolate.gypi, *.isolate, and isolator.py?

Yes, I'll update OWNERS files.

lgtm

[erikwright (departed), 2015-05-04 15:25:37]

erikwright@chromium.org changed reviewers:
+ dpranke@chromium.org, jbudorick@chromium.org

[erikwright (departed), 2015-05-04 15:25:38]

dpranke: PTAL for isolate.gypi
jbudorick: PTAL for isolator.py

[jbudorick, 2015-05-04 15:26:45]

isolator.py lgtm

[erikwright (departed), 2015-05-04 19:46:23]

TBR'ing dpranke for the trivial change in isolate.gypi

[erikwright (departed), 2015-05-04 19:46:27]

The CQ bit was checked by erikwright@chromium.org

[erikwright (departed), 2015-05-04 19:46:28]

The patchset sent to the CQ was uploaded after l-g-t-m from csharp@chromium.org
Link to the patchset: https://codereview.chromium.org/1120083003/#ps40001
(title: "More review comments.")

[commit-bot: I haz the power, 2015-05-04 19:48:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1120083003/40001

[Dirk Pranke, 2015-05-04 20:58:17]

lgtm

[commit-bot: I haz the power, 2015-05-04 21:19:50]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-05-04 21:20:48]

Patchset 3 (id:??) landed as
https://crrev.com/55414130d4ce0ccf2105e3189acd77de926beeb7
Cr-Commit-Position: refs/heads/master@{#328185}