Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(577)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1120043002: Implement support for non-scale/translate CTM in image filters. (Closed)

Created:
5 years, 7 months ago by reed1
Modified:
5 years, 7 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Implement support for non-scale/translate CTM in image filters. Implemented by extracting out the non-scale/translate components and applying that post-filter as an SkMatrixImageFilter. BUG=skia: Committed: https://skia.googlesource.com/skia/+/4f12b8bd2cb43daeffa4d1c53120ae94c5ccf486

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Total comments: 2

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -7 lines) Patch
M include/core/SkCanvas.h View 1 2 2 chunks +2 lines, -1 line 0 comments Download
M src/core/SkCanvas.cpp View 1 2 3 7 chunks +33 lines, -6 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
reed1
manual rebasing and tweaking of Stephen's prev CL (mine proved mind-blowingly hard to rebase, so ...
5 years, 7 months ago (2015-05-01 21:15:38 UTC) #2
robertphillips
https://codereview.chromium.org/1120043002/diff/40001/src/core/SkCanvas.cpp File src/core/SkCanvas.cpp (right): https://codereview.chromium.org/1120043002/diff/40001/src/core/SkCanvas.cpp#newcode1007 src/core/SkCanvas.cpp:1007: this->internalSetMatrix(SkMatrix::MakeScale(scale.width(), scale.height())); \n somewhere ?
5 years, 7 months ago (2015-05-04 14:12:39 UTC) #3
Stephen White
Looks fine to me, once you folks are ok with it.
5 years, 7 months ago (2015-05-05 17:41:25 UTC) #4
reed1
thanks. I'm currently side-tracked on SkImage issues (and drawSprite).
5 years, 7 months ago (2015-05-05 18:36:49 UTC) #5
reed1
https://codereview.chromium.org/1120043002/diff/40001/src/core/SkCanvas.cpp File src/core/SkCanvas.cpp (right): https://codereview.chromium.org/1120043002/diff/40001/src/core/SkCanvas.cpp#newcode1007 src/core/SkCanvas.cpp:1007: this->internalSetMatrix(SkMatrix::MakeScale(scale.width(), scale.height())); On 2015/05/04 14:12:38, robertphillips wrote: > \n ...
5 years, 7 months ago (2015-05-13 19:53:15 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120043002/60001
5 years, 7 months ago (2015-05-13 19:53:33 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-13 19:59:34 UTC) #10
robertphillips
lgtm
5 years, 7 months ago (2015-05-13 20:25:28 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1120043002/60001
5 years, 7 months ago (2015-05-13 20:34:43 UTC) #13
commit-bot: I haz the power
Committed patchset #4 (id:60001) as https://skia.googlesource.com/skia/+/4f12b8bd2cb43daeffa4d1c53120ae94c5ccf486
5 years, 7 months ago (2015-05-13 20:35:02 UTC) #14
reed1
5 years, 7 months ago (2015-05-13 20:59:26 UTC) #15
Message was sent while issue was closed. 
A revert of this CL (patchset #4 id:60001) has been created in
https://codereview.chromium.org/1128133005/ by reed@google.com.

The reason for reverting is: don't reference layer after its deleted.

Powered by Google App Engine
This is Rietveld 408576698