Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1339)

Unified Diff: Source/core/svg/SVGAnimatedNewPropertyAnimator.cpp

Issue 112003003: [SVG] SVGLength{,List} migration to new SVG property impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: revert aggressive svgAttributeChanged, add NeedsRebaseline Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/svg/SVGAnimatedNewPropertyAnimator.h ('k') | Source/core/svg/SVGAnimatedType.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/svg/SVGAnimatedNewPropertyAnimator.cpp
diff --git a/Source/core/svg/SVGAnimatedNewPropertyAnimator.cpp b/Source/core/svg/SVGAnimatedNewPropertyAnimator.cpp
index 0fbec3453f9cfda0fa34645f2989b8756debdd5e..b23b8b20b64f6a997fb38ad7a29550e16d509d51 100644
--- a/Source/core/svg/SVGAnimatedNewPropertyAnimator.cpp
+++ b/Source/core/svg/SVGAnimatedNewPropertyAnimator.cpp
@@ -69,8 +69,39 @@ PassRefPtr<NewSVGPropertyBase> SVGAnimatedNewPropertyAnimator::createPropertyFor
// Create a basic instance of the corresponding SVG property.
// The instance will not have full context info. (e.g. SVGLengthMode)
- // FIXME: add impls here for NewSVGProperty migrated property impls.
- // http://crbug.com/308818
+ switch (m_type) {
+ case AnimatedLength: {
+ RefPtr<SVGLength> property = SVGLength::create(LengthModeOther);
+ property->setValueAsString(value, IGNORE_EXCEPTION);
+ return property.release();
+ }
+ case AnimatedLengthList: {
+ RefPtr<SVGLengthList> property = SVGLengthList::create(LengthModeOther);
+ property->setValueAsString(value, IGNORE_EXCEPTION);
+ return property.release();
+ }
+
+ // These properties are not yet migrated to NewProperty implementation. see http://crbug.com/308818
+ case AnimatedAngle:
+ case AnimatedBoolean:
+ case AnimatedColor:
+ case AnimatedEnumeration:
+ case AnimatedInteger:
+ case AnimatedIntegerOptionalInteger:
+ case AnimatedNumber:
+ case AnimatedNumberList:
+ case AnimatedNumberOptionalNumber:
+ case AnimatedPath:
+ case AnimatedPoints:
+ case AnimatedPreserveAspectRatio:
+ case AnimatedRect:
+ case AnimatedString:
+ case AnimatedTransformList:
+ ASSERT_NOT_REACHED();
+
+ case AnimatedUnknown:
+ ASSERT_NOT_REACHED();
+ };
ASSERT_NOT_REACHED();
return 0;
« no previous file with comments | « Source/core/svg/SVGAnimatedNewPropertyAnimator.h ('k') | Source/core/svg/SVGAnimatedType.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698