Source/core/rendering/svg/SVGTextChunkBuilder.cpp - Issue 112003003: [SVG] SVGLength{,List} migration to new SVG property impl.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/rendering/svg/SVGTextChunkBuilder.cpp

Issue 112003003: [SVG] SVGLength{,List} migration to new SVG property impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: revert aggressive svgAttributeChanged, add NeedsRebaseline Created 6 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/rendering/svg/SVGTextChunkBuilder.cpp

diff --git a/Source/core/rendering/svg/SVGTextChunkBuilder.cpp b/Source/core/rendering/svg/SVGTextChunkBuilder.cpp

index d26d868fff1e785bb41fb171fbc765be9bb9dce8..3c64a64a25ab9b85ef9cdf8b4538f420dd6fab06 100644

--- a/Source/core/rendering/svg/SVGTextChunkBuilder.cpp

+++ b/Source/core/rendering/svg/SVGTextChunkBuilder.cpp

@@ -127,7 +127,10 @@ void SVGTextChunkBuilder::addTextChunk(Vector<SVGInlineTextBox*>& lineLayoutBoxe

float desiredTextLength = 0;

if (SVGTextContentElement* textContentElement = SVGTextContentElement::elementFromRenderer(textRenderer->parent())) {

SVGLengthContext lengthContext(textContentElement);

- desiredTextLength = textContentElement->specifiedTextLength().value(lengthContext);

+ if (textContentElement->textLengthIsSpecifiedByUser())

+ desiredTextLength = textContentElement->textLength()->currentValue()->value(lengthContext);

+ else

+ desiredTextLength = 0;

switch (textContentElement->lengthAdjustCurrentValue()) {

case SVGLengthAdjustUnknown: