Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1082)

Unified Diff: Source/core/rendering/style/SVGRenderStyleDefs.cpp

Issue 112003003: [SVG] SVGLength{,List} migration to new SVG property impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: revert aggressive svgAttributeChanged, add NeedsRebaseline Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/rendering/style/SVGRenderStyleDefs.h ('k') | Source/core/rendering/svg/RenderSVGEllipse.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/rendering/style/SVGRenderStyleDefs.cpp
diff --git a/Source/core/rendering/style/SVGRenderStyleDefs.cpp b/Source/core/rendering/style/SVGRenderStyleDefs.cpp
index 56e4a06ed5f7c3f764cd0ec789333b9f5573109c..820295334b427b7df71e71dff5695509b62522d0 100644
--- a/Source/core/rendering/style/SVGRenderStyleDefs.cpp
+++ b/Source/core/rendering/style/SVGRenderStyleDefs.cpp
@@ -86,9 +86,9 @@ StyleStrokeData::StyleStrokeData(const StyleStrokeData& other)
: RefCounted<StyleStrokeData>()
, opacity(other.opacity)
, miterLimit(other.miterLimit)
- , width(other.width)
- , dashOffset(other.dashOffset)
- , dashArray(other.dashArray)
+ , width(other.width->clone())
+ , dashOffset(other.dashOffset->clone())
+ , dashArray(other.dashArray->clone())
, paintType(other.paintType)
, paintColor(other.paintColor)
, paintUri(other.paintUri)
@@ -100,11 +100,11 @@ StyleStrokeData::StyleStrokeData(const StyleStrokeData& other)
bool StyleStrokeData::operator==(const StyleStrokeData& other) const
{
- return width == other.width
+ return *width == *other.width
&& opacity == other.opacity
&& miterLimit == other.miterLimit
- && dashOffset == other.dashOffset
- && dashArray == other.dashArray
+ && *dashOffset == *other.dashOffset
+ && *dashArray == *other.dashArray
&& paintType == other.paintType
&& paintColor == other.paintColor
&& paintUri == other.paintUri
@@ -139,13 +139,13 @@ StyleTextData::StyleTextData()
StyleTextData::StyleTextData(const StyleTextData& other)
: RefCounted<StyleTextData>()
- , kerning(other.kerning)
+ , kerning(other.kerning->clone())
{
}
bool StyleTextData::operator==(const StyleTextData& other) const
{
- return kerning == other.kerning;
+ return *kerning == *other.kerning;
}
StyleMiscData::StyleMiscData()
@@ -161,7 +161,7 @@ StyleMiscData::StyleMiscData(const StyleMiscData& other)
, floodColor(other.floodColor)
, floodOpacity(other.floodOpacity)
, lightingColor(other.lightingColor)
- , baselineShiftValue(other.baselineShiftValue)
+ , baselineShiftValue(other.baselineShiftValue->clone())
{
}
@@ -170,7 +170,7 @@ bool StyleMiscData::operator==(const StyleMiscData& other) const
return floodOpacity == other.floodOpacity
&& floodColor == other.floodColor
&& lightingColor == other.lightingColor
- && baselineShiftValue == other.baselineShiftValue;
+ && *baselineShiftValue == *other.baselineShiftValue;
}
StyleResourceData::StyleResourceData()
« no previous file with comments | « Source/core/rendering/style/SVGRenderStyleDefs.h ('k') | Source/core/rendering/svg/RenderSVGEllipse.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698