Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(264)

Unified Diff: Source/bindings/scripts/code_generator_v8.pm

Issue 112003003: [SVG] SVGLength{,List} migration to new SVG property impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: revert aggressive svgAttributeChanged, add NeedsRebaseline Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/bindings.gypi ('k') | Source/bindings/v8/custom/V8SVGLengthCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/scripts/code_generator_v8.pm
diff --git a/Source/bindings/scripts/code_generator_v8.pm b/Source/bindings/scripts/code_generator_v8.pm
index 74351603f480d5393a49c7b95c0c03d3f5d058f8..2f68c7d1b66d57919d98cdd6ad30475be6f829f4 100644
--- a/Source/bindings/scripts/code_generator_v8.pm
+++ b/Source/bindings/scripts/code_generator_v8.pm
@@ -233,10 +233,13 @@ my %svgAttributesInHTMLHash = ("class" => 1, "id" => 1, "onabort" => 1, "onclick
"onmouseup" => 1, "onresize" => 1, "onscroll" => 1,
"onunload" => 1);
+my %svgTypeNewPropertyImplementation = (
+ "SVGLength" => 1,
+ "SVGLengthList" => 1,
+);
+
my %svgTypeNeedingTearOff = (
"SVGAngle" => "SVGPropertyTearOff<SVGAngle>",
- "SVGLength" => "SVGPropertyTearOff<SVGLength>",
- "SVGLengthList" => "SVGListPropertyTearOff<SVGLengthList>",
"SVGMatrix" => "SVGMatrixTearOff",
"SVGNumber" => "SVGPropertyTearOff<SVGNumber>",
"SVGNumberList" => "SVGListPropertyTearOff<SVGNumberList>",
@@ -6034,6 +6037,8 @@ sub IsSVGAnimatedType
{
my $type = shift;
+ return 0 if $svgTypeNewPropertyImplementation{$type};
+
return $type =~ /^SVGAnimated/;
}
« no previous file with comments | « Source/bindings/bindings.gypi ('k') | Source/bindings/v8/custom/V8SVGLengthCustom.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698