Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(571)

Side by Side Diff: Source/core/css/resolver/StyleBuilderCustom.cpp

Issue 112003003: [SVG] SVGLength{,List} migration to new SVG property impl. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: fix tests Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 3 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
4 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com) 4 * (C) 2004-2005 Allan Sandfeld Jensen (kde@carewolf.com)
5 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com) 5 * Copyright (C) 2006, 2007 Nicholas Shanks (webkit@nickshanks.com)
6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved. 6 * Copyright (C) 2005, 2006, 2007, 2008, 2009, 2010, 2011, 2012, 2013 Apple Inc. All rights reserved.
7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org> 7 * Copyright (C) 2007 Alexey Proskuryakov <ap@webkit.org>
8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org> 8 * Copyright (C) 2007, 2008 Eric Seidel <eric@webkit.org>
9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/) 9 * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.t orchmobile.com/)
10 * Copyright (c) 2011, Code Aurora Forum. All rights reserved. 10 * Copyright (c) 2011, Code Aurora Forum. All rights reserved.
(...skipping 2061 matching lines...) Expand 10 before | Expand all | Expand 10 after
2072 case CSSPropertyStrokeDasharray: 2072 case CSSPropertyStrokeDasharray:
2073 { 2073 {
2074 HANDLE_SVG_INHERIT_AND_INITIAL(strokeDashArray, StrokeDashArray) 2074 HANDLE_SVG_INHERIT_AND_INITIAL(strokeDashArray, StrokeDashArray)
2075 if (!value->isValueList()) { 2075 if (!value->isValueList()) {
2076 state.style()->accessSVGStyle()->setStrokeDashArray(SVGRenderStyle:: initialStrokeDashArray()); 2076 state.style()->accessSVGStyle()->setStrokeDashArray(SVGRenderStyle:: initialStrokeDashArray());
2077 break; 2077 break;
2078 } 2078 }
2079 2079
2080 CSSValueList* dashes = toCSSValueList(value); 2080 CSSValueList* dashes = toCSSValueList(value);
2081 2081
2082 Vector<SVGLength> array; 2082 RefPtr<SVGLengthList> array = SVGLengthList::create();
2083 size_t length = dashes->length(); 2083 size_t length = dashes->length();
2084 for (size_t i = 0; i < length; ++i) { 2084 for (size_t i = 0; i < length; ++i) {
2085 CSSValue* currValue = dashes->itemWithoutBoundsCheck(i); 2085 CSSValue* currValue = dashes->itemWithoutBoundsCheck(i);
2086 if (!currValue->isPrimitiveValue()) 2086 if (!currValue->isPrimitiveValue())
2087 continue; 2087 continue;
2088 2088
2089 CSSPrimitiveValue* dash = toCSSPrimitiveValue(dashes->itemWithoutBou ndsCheck(i)); 2089 CSSPrimitiveValue* dash = toCSSPrimitiveValue(dashes->itemWithoutBou ndsCheck(i));
2090 array.append(SVGLength::fromCSSPrimitiveValue(dash)); 2090 array->append(SVGLength::fromCSSPrimitiveValue(dash));
2091 } 2091 }
2092 2092
2093 state.style()->accessSVGStyle()->setStrokeDashArray(array); 2093 state.style()->accessSVGStyle()->setStrokeDashArray(array.release());
2094 break; 2094 break;
2095 } 2095 }
2096 case CSSPropertyStopColor: 2096 case CSSPropertyStopColor:
2097 { 2097 {
2098 HANDLE_SVG_INHERIT_AND_INITIAL(stopColor, StopColor); 2098 HANDLE_SVG_INHERIT_AND_INITIAL(stopColor, StopColor);
2099 if (value->isSVGColor()) 2099 if (value->isSVGColor())
2100 state.style()->accessSVGStyle()->setStopColor(colorFromSVGColorCSSVa lue(toSVGColor(value), state.style()->color())); 2100 state.style()->accessSVGStyle()->setStopColor(colorFromSVGColorCSSVa lue(toSVGColor(value), state.style()->color()));
2101 break; 2101 break;
2102 } 2102 }
2103 case CSSPropertyLightingColor: 2103 case CSSPropertyLightingColor:
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
2141 break; 2141 break;
2142 } 2142 }
2143 case CSSPropertyEnableBackground: 2143 case CSSPropertyEnableBackground:
2144 // Silently ignoring this property for now 2144 // Silently ignoring this property for now
2145 // http://bugs.webkit.org/show_bug.cgi?id=6022 2145 // http://bugs.webkit.org/show_bug.cgi?id=6022
2146 break; 2146 break;
2147 } 2147 }
2148 } 2148 }
2149 2149
2150 } // namespace WebCore 2150 } // namespace WebCore
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698