Add right-click user switching tutorial bubble.

chrome/browser/profiles/profiles_state.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/profiles/profiles_state.h"
 
 #include "base/files/file_path.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/strings/utf_string_conversions.h"
@@ skipping 35 matching lines @@
 
 void RegisterPrefs(PrefRegistrySimple* registry) {
   // Preferences about global profile information.
   registry->RegisterStringPref(prefs::kProfileLastUsed, std::string());
   registry->RegisterIntegerPref(prefs::kProfilesNumCreated, 1);
   registry->RegisterListPref(prefs::kProfilesLastActive);
 
   // Preferences about the user manager.
   registry->RegisterBooleanPref(prefs::kBrowserGuestModeEnabled, true);
   registry->RegisterBooleanPref(prefs::kBrowserAddPersonEnabled, true);
+
+  registry->RegisterBooleanPref(

[Mike Lerman, 2015/05/05 01:31:45]

Let's register this near where the other tutorial prefs are - in profile.cc,
line 149. Where prefs::kProfileAvatarTutorialShown, is registered.

[anthonyvd, 2015/05/05 16:19:17]

I put it here because the tutorial prefs in profile.cc are profile-specific
where this one has to be consistent across all profiles and this is where we
seem to register those. 

[Mike Lerman, 2015/05/05 17:18:09]

So we show it once per Chrome, not one per Profile? Wouldn't each profile
(meat-person) want to see the tutorial? Although I guess this is targeting power
users... so I can see how it makes sense to be per-Chrome.

+      prefs::kProfileAvatarRightClickTutorialDismissed, false);
 }
 
 base::string16 GetAvatarNameForProfile(const base::FilePath& profile_path) {
   base::string16 display_name;
 
   if (profile_path == ProfileManager::GetGuestProfilePath()) {
     display_name = l10n_util::GetStringUTF16(IDS_GUEST_PROFILE_NAME);
   } else {
     const ProfileInfoCache& cache =
         g_browser_process->profile_manager()->GetProfileInfoCache();
@@ skipping 164 matching lines @@
 
   // For guest the browsing data is in the OTR profile.
   if (profile->IsGuestSession())
     profile = profile->GetOffTheRecordProfile();
 
   BrowsingDataRemover::CreateForUnboundedRange(profile)->Remove(
       BrowsingDataRemover::REMOVE_ALL, BrowsingDataHelper::ALL);
   // BrowsingDataRemover deletes itself.
 }
 
+void SetFastUserSwitchingTutorialDismissedState(bool dismissed) {

[Mike Lerman, 2015/05/05 01:31:45]

We usually just directly access this type of preference directly. Any reason we
need to wrap that access in these two functions?

[anthonyvd, 2015/05/05 16:19:17]

I guess it just... happened. There no need really, so they're now accessed
directly! 

+  PrefService* local_state = g_browser_process->local_state();
+  local_state->SetBoolean(
+      prefs::kProfileAvatarRightClickTutorialDismissed, dismissed);
+}
+
+bool GetFastUserSwitchingTutorialDismissedState() {
+  PrefService* local_state = g_browser_process->local_state();
+  return local_state->GetBoolean(
+      prefs::kProfileAvatarRightClickTutorialDismissed);
+}
+
 }  // namespace profiles