Source/core/animation/EffectModel.h - Issue 1120003002: [Oilpan] Migrate most classes under core/animations to Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/EffectModel.h

Issue 1120003002: [Oilpan] Migrate most classes under core/animations to Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Resize expect size of Persistent Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/animation/AnimationTimeline.cpp ('K') | « Source/core/animation/EffectInputTest.cpp ('k') | Source/core/animation/EffectModel.idl » ('j') | Source/core/animation/KeyframeEffect.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/EffectModel.h

diff --git a/Source/core/animation/EffectModel.h b/Source/core/animation/EffectModel.h

index 2e131940ceaea078f08782e6745e055e3ffa0679..3a34a9ad3ffa0a2fc48b73e88b599b4959a340bc 100644

--- a/Source/core/animation/EffectModel.h

+++ b/Source/core/animation/EffectModel.h

@@ -44,7 +44,7 @@ namespace blink {

class Interpolation;

-class CORE_EXPORT EffectModel : public RefCountedWillBeGarbageCollectedFinalized<EffectModel>, public ScriptWrappable {

+class CORE_EXPORT EffectModel : public GarbageCollectedFinalized<EffectModel>, public ScriptWrappable {

DEFINE_WRAPPERTYPEINFO();

public:

enum CompositeOperation {

@@ -54,7 +54,7 @@ public:

EffectModel() { }

virtual ~EffectModel() { }

- virtual void sample(int iteration, double fraction, double iterationDuration, OwnPtrWillBeRawPtr<WillBeHeapVector<RefPtrWillBeMember<Interpolation>>>&) const = 0;

+ virtual void sample(int iteration, double fraction, double iterationDuration, HeapVector<Member<Interpolation>>*&) const = 0;

virtual bool affects(PropertyHandle) const { return false; };

virtual bool isKeyframeEffectModel() const { return false; }