Source/core/animation/DoubleStyleInterpolation.cpp - Issue 1120003002: [Oilpan] Migrate most classes under core/animations to Oilpan heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/animation/DoubleStyleInterpolation.cpp

Issue 1120003002: [Oilpan] Migrate most classes under core/animations to Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Intentional nullptr access Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« Source/core/animation/AnimationTimelineTest.cpp ('K') | « Source/core/animation/DoubleStyleInterpolation.h ('k') | Source/core/animation/DoubleStyleInterpolationTest.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/animation/DoubleStyleInterpolation.cpp

diff --git a/Source/core/animation/DoubleStyleInterpolation.cpp b/Source/core/animation/DoubleStyleInterpolation.cpp

index ad1989e06916a0225d1e66a0b3aa83a554848849..685c46ea8610db90bf5280fa67804d45eef7aa97 100644

--- a/Source/core/animation/DoubleStyleInterpolation.cpp

+++ b/Source/core/animation/DoubleStyleInterpolation.cpp

@@ -15,7 +15,7 @@ bool DoubleStyleInterpolation::canCreateFrom(const CSSValue& value)

return value.isPrimitiveValue() && (toCSSPrimitiveValue(value).isNumber() || toCSSPrimitiveValue(value).isAngle());

}

-PassOwnPtrWillBeRawPtr<InterpolableValue> DoubleStyleInterpolation::doubleToInterpolableValue(const CSSValue& value)

+InterpolableValue* DoubleStyleInterpolation::doubleToInterpolableValue(const CSSValue& value)

{

ASSERT(canCreateFrom(value));

const CSSPrimitiveValue& primitive = toCSSPrimitiveValue(value);

@@ -123,7 +123,7 @@ PassRefPtrWillBeRawPtr<CSSValue> DoubleStyleInterpolation::interpolableValueToMo

return list.release();

}

-PassOwnPtrWillBeRawPtr<InterpolableValue> DoubleStyleInterpolation::motionRotationToInterpolableValue(const CSSValue& value)

+InterpolableValue* DoubleStyleInterpolation::motionRotationToInterpolableValue(const CSSValue& value)

{

float rotation;

MotionRotationType rotationType;

@@ -132,7 +132,7 @@ PassOwnPtrWillBeRawPtr<InterpolableValue> DoubleStyleInterpolation::motionRotati

return InterpolableNumber::create(rotation);

}

-PassRefPtrWillBeRawPtr<DoubleStyleInterpolation> DoubleStyleInterpolation::maybeCreateFromMotionRotation(const CSSValue& start, const CSSValue& end, CSSPropertyID id)

+DoubleStyleInterpolation* DoubleStyleInterpolation::maybeCreateFromMotionRotation(const CSSValue& start, const CSSValue& end, CSSPropertyID id)

{

float startRotation, endRotation;

MotionRotationType startRotationType, endRotationType;

@@ -142,10 +142,7 @@ PassRefPtrWillBeRawPtr<DoubleStyleInterpolation> DoubleStyleInterpolation::maybe

|| startRotationType != endRotationType)

return nullptr;

- return adoptRefWillBeNoop(new DoubleStyleInterpolation(

- motionRotationToInterpolableValue(start),

- motionRotationToInterpolableValue(end),

- id, true, InterpolationRange::RangeAll, startRotationType == MotionRotationAuto));

+ return new DoubleStyleInterpolation(motionRotationToInterpolableValue(start), motionRotationToInterpolableValue(end), id, true, InterpolationRange::RangeAll, startRotationType == MotionRotationAuto);

}