Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(340)

Unified Diff: Source/core/animation/Animation.h

Issue 1120003002: [Oilpan] Migrate most classes under core/animations to Oilpan heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Intentional nullptr access Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/animation/Animation.h
diff --git a/Source/core/animation/Animation.h b/Source/core/animation/Animation.h
index 9433247fc0d0123e040addddd974c88df979471b..818da9f6d6a299c727967085934053d96116c799 100644
--- a/Source/core/animation/Animation.h
+++ b/Source/core/animation/Animation.h
@@ -51,12 +51,7 @@ class Element;
class ExceptionState;
class WebCompositorAnimationPlayer;
-class CORE_EXPORT Animation final
- : public EventTargetWithInlineData
- , public RefCountedWillBeNoBase<Animation>
- , public ActiveDOMObject
- , public WebCompositorAnimationDelegate
- , public WebCompositorAnimationPlayerClient {
+class CORE_EXPORT Animation final : public EventTargetWithInlineData, public RefCountedWillBeNoBase<Animation>, public ActiveDOMObject, public WebCompositorAnimationDelegate, public WebCompositorAnimationPlayerClient {
DEFINE_WRAPPERTYPEINFO();
REFCOUNTED_EVENT_TARGET(Animation);
WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(Animation);
@@ -213,8 +208,8 @@ private:
PersistentWillBeMember<AnimationPromise> m_finishedPromise;
PersistentWillBeMember<AnimationPromise> m_readyPromise;
- RefPtrWillBeMember<AnimationEffect> m_content;
- RawPtrWillBeMember<AnimationTimeline> m_timeline;
+ PersistentWillBeMember<AnimationEffect> m_content;
+ PersistentWillBeMember<AnimationTimeline> m_timeline;
// Reflects all pausing, including via pauseForTesting().
bool m_paused;
bool m_held;

Powered by Google App Engine
This is Rietveld 408576698