Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1119983006: [ash/shelf] ResourceBundle should be used as pointer not non-const ref (Closed)

Created:
5 years, 7 months ago by anujsharma
Modified:
5 years, 7 months ago
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Modifying the code to retrieve a pointer rather than a non-const reference in ash/shelf module. ResourceBundle::GetSharedInstance() returns a non-const reference, but it will be changed to return a pointer, so updating the code to use it as a pointer BUG=289640 Committed: https://crrev.com/668c3a429ee911ac96d7b4a4f8eefdbdc9f0abe3 Cr-Commit-Position: refs/heads/master@{#328334}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -10 lines) Patch
M ash/shelf/overflow_button.cc View 1 chunk +2 lines, -3 lines 0 comments Download
M ash/shelf/shelf_view.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M ash/shelf/shelf_widget.cc View 3 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
anujsharma
PTAL
5 years, 7 months ago (2015-05-05 14:13:14 UTC) #2
Mr4D (OOO till 08-26)
lgtm
5 years, 7 months ago (2015-05-05 14:22:25 UTC) #3
anujsharma
On 2015/05/05 14:22:25, Mr4D wrote: > lgtm Thanks Mr4D for lgtm.
5 years, 7 months ago (2015-05-05 14:22:55 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119983006/1
5 years, 7 months ago (2015-05-05 14:23:09 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 15:32:31 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 15:33:33 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/668c3a429ee911ac96d7b4a4f8eefdbdc9f0abe3
Cr-Commit-Position: refs/heads/master@{#328334}

Powered by Google App Engine
This is Rietveld 408576698