Issue 1119983003: Revert of [Telemetry] Change HTMLOutputFormatter to be based on chart JSON

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1119983003: Revert of [Telemetry] Change HTMLOutputFormatter to be based on chart JSON (Closed)

Created:
5 years, 7 months ago by eakuefner

Modified:
5 years, 7 months ago

Reviewers:
nednguyen

CC:
chromium-reviews, telemetry-reviews_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

Revert of [Telemetry] Change HTMLOutputFormatter to be based on chart JSON (patchset #4 id:60001 of https://codereview.chromium.org/1118593002/) Reason for revert: Broke perf trybots Original issue's description: > [Telemetry] Change HTMLOutputFormatter to be based on chart JSON > > This CL modifies HTMLOutputFormatter so that it is no longer based on Buildbot output. > > BUG=477056 > > Committed: https://crrev.com/d522cf5a1615d2b1fdf5e1e9b3f385f75d687c1a > Cr-Commit-Position: refs/heads/master@{#327830} TBR=nednguyen@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=477056 Committed: https://crrev.com/fa1a748b8ab91ff2ea31b3de28cd80575761dd22 Cr-Commit-Position: refs/heads/master@{#327890}

Created: 5 years, 7 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+48 lines, -54 lines)			Patch
M	tools/telemetry/telemetry/results/chart_json_output_formatter.py	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	tools/telemetry/telemetry/results/chart_json_output_formatter_unittest.py	View	9 chunks	+9 lines, -9 lines	0 comments	Download
M	tools/telemetry/telemetry/results/html_output_formatter.py	View	7 chunks	+16 lines, -42 lines	0 comments	Download
M	tools/telemetry/telemetry/results/html_output_formatter_unittest.py	View	4 chunks	+20 lines, -0 lines	0 comments	Download
M	tools/telemetry/telemetry/results/results_options.py	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 4 (0 generated)

eakuefner

Created Revert of [Telemetry] Change HTMLOutputFormatter to be based on chart JSON

5 years, 7 months ago (2015-05-01 07:18:16 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119983003/1

5 years, 7 months ago (2015-05-01 07:18:40 UTC) #2

commit-bot: I haz the power

5 years, 7 months ago (2015-05-01 07:20:33 UTC) #4

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/fa1a748b8ab91ff2ea31b3de28cd80575761dd22
Cr-Commit-Position: refs/heads/master@{#327890}