Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(1)

Issue 1119983002: Allow whitespace at end of :not() pseudo-class, i.e. :not(div ) (Closed)

Created:
5 years ago by Timothy Loh
Modified:
5 years ago
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, dglazkov+blink, ed+blinkwatch_opera.com, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Allow whitespace at end of :not() pseudo-class, i.e. :not(div ) This patch fixes a bug in the (new) CSS selector parser where we would reject :not() pseudo-classes with trailing whitespace. Note that our current implementation or :not() is partway between the level 3 and 4 specs, where we allow compound selectors instead of simple selectors and selector lists respectively. BUG=482221 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194795

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -0 lines) Patch
A LayoutTests/css-parser/not-pseudo-class-whitespace.html View 1 chunk +15 lines, -0 lines 0 comments Download
M Source/core/css/parser/CSSSelectorParser.cpp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Timothy Loh
5 years ago (2015-05-01 04:41:59 UTC) #2
dstockwell
lgtm
5 years ago (2015-05-01 06:37:02 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119983002/1
5 years ago (2015-05-01 06:37:15 UTC) #5
commit-bot: I haz the power
5 years ago (2015-05-01 07:46:47 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194795

Powered by Google App Engine
This is Rietveld 408576698