Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Issue 1119963003: Revert of [turbofan] Small fixes to PipelineStatistics. Collect statistics in tests. (Closed)

Created:
5 years, 7 months ago by Michael Achenbach
Modified:
5 years, 7 months ago
Reviewers:
Benedikt Meurer, titzer
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of [turbofan] Small fixes to PipelineStatistics. Collect statistics in tests. (patchset #1 id:1 of https://codereview.chromium.org/1122753002/) Reason for revert: [Sheriff] Speculative revert for breaking arm64 nosnap: http://build.chromium.org/p/client.v8/builders/V8%20Linux%20-%20arm64%20-%20sim%20-%20nosnap%20-%20debug%20-%202/builds/2314 Original issue's description: > [turbofan] Small fixes to PipelineStatistics. Collect statistics in tests. > > R=bmeurer@chromium.org > BUG= > > Committed: https://crrev.com/9833844268357590243732a53e2a7fc0dc5fcc9e > Cr-Commit-Position: refs/heads/master@{#28192} TBR=bmeurer@chromium.org,titzer@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/d0ed8940fc6c995eba57149b8e8cb214001e8381 Cr-Commit-Position: refs/heads/master@{#28205}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -7 lines) Patch
M src/compiler/pipeline.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M src/compiler/pipeline-statistics.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
Michael Achenbach
Created Revert of [turbofan] Small fixes to PipelineStatistics. Collect statistics in tests.
5 years, 7 months ago (2015-05-04 15:38:43 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119963003/1
5 years, 7 months ago (2015-05-04 15:38:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-04 15:39:48 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/d0ed8940fc6c995eba57149b8e8cb214001e8381 Cr-Commit-Position: refs/heads/master@{#28205}
5 years, 7 months ago (2015-05-04 15:40:00 UTC) #4
Michael Achenbach
5 years, 7 months ago (2015-05-04 16:47:30 UTC) #5
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/1126603002/ by machenbach@chromium.org.

The reason for reverting is: Revert didn't fix the problem. Maybe it was another
CL..

Powered by Google App Engine
This is Rietveld 408576698