Enable display rotation, magnifier in unified desktop mode

Enable display rotation, magnifier in unified desktop mode

Move  SetDefaultMultiDisplayMode back to DisplayManager. We'll have to support dynamic switch from/to Unified desktop mode.

BUG=365662, 483810
TEST=DisplayManagerTest.RotateUnifiedDesktop,MagnificationControllerTest.EnableMagnifierInUnifiedDesktop

Committed: https://crrev.com/38dffadd1f16d7378a7c58b847fca47ac0ad7e17
Cr-Commit-Position: refs/heads/master@{#328348}

[oshima, 2015-05-01 03:34:13]

Patchset #1 (id:1) has been deleted

[oshima, 2015-05-01 04:09:11]

oshima@chromium.org changed reviewers:
+ mukai@chromium.org

[oshima, 2015-05-01 04:11:18]

https://codereview.chromium.org/1119953002/diff/40001/ash/host/ash_window_tre...
File ash/host/ash_window_tree_host_unified.cc (right):

https://codereview.chromium.org/1119953002/diff/40001/ash/host/ash_window_tre...
ash/host/ash_window_tree_host_unified.cc:52: transformer_helper_.Init();
Initialize transformer_helper requires window(), which is created in
CreateCompositor().

[oshima, 2015-05-01 04:11:25]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[oshima, 2015-05-01 04:11:33]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2015-05-01 04:11:46]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1119953002/40001

[commit-bot: I haz the power, 2015-05-01 04:55:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-01 04:55:56]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2015-05-01 15:10:37]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-01 15:11:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1119953002/60001

[commit-bot: I haz the power, 2015-05-01 15:56:52]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-01 15:56:53]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2015-05-01 16:49:50]

please hold. win bots are failing for a reason I don't know.

[oshima, 2015-05-01 19:58:27]

Patchset #4 (id:100001) has been deleted

[oshima, 2015-05-01 19:58:32]

Patchset #3 (id:80001) has been deleted

[oshima, 2015-05-01 20:01:04]

Patchset #2 (id:60001) has been deleted

[oshima, 2015-05-01 20:01:12]

Patchset #2 (id:120001) has been deleted

[oshima, 2015-05-01 20:01:18]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-01 20:02:55]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1119953002/140001

[oshima, 2015-05-01 20:58:16]

I'm still looking into why tests are failing on win and ozone, but I don't think
it'll change this CL that much.
Please take a look.

https://codereview.chromium.org/1119953002/diff/140001/ash/display/display_ma...
File ash/display/display_manager_unittest.cc (right):

https://codereview.chromium.org/1119953002/diff/140001/ash/display/display_ma...
ash/display/display_manager_unittest.cc:1493: #if !defined(USE_OZONE)
here

https://codereview.chromium.org/1119953002/diff/140001/ash/host/transformer_h...
File ash/host/transformer_helper.cc (right):

https://codereview.chromium.org/1119953002/diff/140001/ash/host/transformer_h...
ash/host/transformer_helper.cc:62: Init();
here

[Jun Mukai, 2015-05-01 22:06:07]

https://codereview.chromium.org/1119953002/diff/140001/ash/display/display_ma...
File ash/display/display_manager.h (right):

https://codereview.chromium.org/1119953002/diff/140001/ash/display/display_ma...
ash/display/display_manager.h:295: void
SetDefaultMultiDisplayMode(MultiDisplayMode mode);
What is the motivation to make this public again?
Still only test code invokes this, so I think it's still okay to be in the test
api.

https://codereview.chromium.org/1119953002/diff/140001/ash/host/transformer_h...
File ash/host/transformer_helper.cc (right):

https://codereview.chromium.org/1119953002/diff/140001/ash/host/transformer_h...
ash/host/transformer_helper.cc:62: Init();
I'm not sure what's this is for.
_ozone, _x11, and _unified invoke Init() on its constructor, and the helper is
constructed inside of the class.  The last implementation is _win, and for
windows it invokes Init() here.
Why you create Init, and why it's not always invoked here?

https://codereview.chromium.org/1119953002/diff/140001/ash/magnifier/magnific...
File ash/magnifier/magnification_controller.cc (right):

https://codereview.chromium.org/1119953002/diff/140001/ash/magnifier/magnific...
ash/magnifier/magnification_controller.cc:386: aura::Window* new_root_window,
This is named as |window| in the header file.

https://codereview.chromium.org/1119953002/diff/140001/ash/magnifier/magnific...
File ash/magnifier/magnification_controller.h (right):

https://codereview.chromium.org/1119953002/diff/140001/ash/magnifier/magnific...
ash/magnifier/magnification_controller.h:74: // Switch Magnified RootWindow to
|new_root_window|. This does following:
|window| ?
Also s/RootWindow/Window/ (or root window?)

[commit-bot: I haz the power, 2015-05-01 22:06:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-01 22:06:10]

Dry run: This issue passed the CQ dry run.

[oshima, 2015-05-01 22:44:57]

https://codereview.chromium.org/1119953002/diff/140001/ash/display/display_ma...
File ash/display/display_manager.h (right):

https://codereview.chromium.org/1119953002/diff/140001/ash/display/display_ma...
ash/display/display_manager.h:295: void
SetDefaultMultiDisplayMode(MultiDisplayMode mode);
On 2015/05/01 22:06:07, Jun Mukai wrote:
> What is the motivation to make this public again?
> Still only test code invokes this, so I think it's still okay to be in the
test
> api.

Turns out that this needs to be configurable. About flags will be used to
control if this option is available in the settings.

https://codereview.chromium.org/1119953002/diff/140001/ash/host/transformer_h...
File ash/host/transformer_helper.cc (right):

https://codereview.chromium.org/1119953002/diff/140001/ash/host/transformer_h...
ash/host/transformer_helper.cc:62: Init();
On 2015/05/01 22:06:07, Jun Mukai wrote:
> I'm not sure what's this is for.
> _ozone, _x11, and _unified invoke Init() on its constructor, and the helper is
> constructed inside of the class.  The last implementation is _win, and for
> windows it invokes Init() here.
> Why you create Init, and why it's not always invoked here?

As I mentioned, I'm still investigating but windows seems to have slightly
different call path.

https://codereview.chromium.org/1119953002/diff/140001/ash/magnifier/magnific...
File ash/magnifier/magnification_controller.cc (right):

https://codereview.chromium.org/1119953002/diff/140001/ash/magnifier/magnific...
ash/magnifier/magnification_controller.cc:386: aura::Window* new_root_window,
On 2015/05/01 22:06:07, Jun Mukai wrote:
> This is named as |window| in the header file.

updated the header

https://codereview.chromium.org/1119953002/diff/140001/ash/magnifier/magnific...
File ash/magnifier/magnification_controller.h (right):

https://codereview.chromium.org/1119953002/diff/140001/ash/magnifier/magnific...
ash/magnifier/magnification_controller.h:74: // Switch Magnified RootWindow to
|new_root_window|. This does following:
On 2015/05/01 22:06:07, Jun Mukai wrote:
> |window| ?
> Also s/RootWindow/Window/ (or root window?)

Updated the comment.

[Jun Mukai, 2015-05-01 22:47:09]

looks okay, ping me once the windows/ozone tests have passed. I'll take another
look then.

[oshima, 2015-05-02 02:10:20]

Patchset #4 (id:180001) has been deleted

[oshima, 2015-05-02 02:10:26]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-02 02:10:40]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1119953002/200001

[oshima, 2015-05-02 02:12:25]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[oshima, 2015-05-02 02:12:34]

Patchset #4 (id:200001) has been deleted

[commit-bot: I haz the power, 2015-05-02 02:12:37]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1119953002/220001

[commit-bot: I haz the power, 2015-05-02 02:56:36]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-02 02:56:37]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2015-05-02 03:25:57]

Patchset #4 (id:220001) has been deleted

[oshima, 2015-05-02 03:26:04]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-02 03:26:11]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1119953002/240001

[commit-bot: I haz the power, 2015-05-02 04:08:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-02 04:08:59]

Dry run: This issue passed the CQ dry run.

[oshima, 2015-05-05 04:39:21]

The CQ bit was checked by oshima@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2015-05-05 04:41:36]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1119953002/260001

[commit-bot: I haz the power, 2015-05-05 05:09:05]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-05-05 05:09:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[oshima, 2015-05-05 15:32:13]

PTAL

https://codereview.chromium.org/1119953002/diff/300001/ash/display/display_co...
File ash/display/display_controller.cc (right):

https://codereview.chromium.org/1119953002/diff/300001/ash/display/display_co...
ash/display/display_controller.cc:598: return;
this was ozone issue.

https://codereview.chromium.org/1119953002/diff/300001/ash/host/ash_remote_wi...
File ash/host/ash_remote_window_tree_host_win.cc (right):

https://codereview.chromium.org/1119953002/diff/300001/ash/host/ash_remote_wi...
ash/host/ash_remote_window_tree_host_win.cc:17: transformer_helper_.Init();
I forgot about this file and that's the reason why ash_unittests was failing. My
bad.

[Jun Mukai, 2015-05-05 16:29:22]

lgtm

[oshima, 2015-05-05 16:44:22]

The CQ bit was checked by oshima@chromium.org

[oshima, 2015-05-05 16:44:26]

The CQ bit was unchecked by oshima@chromium.org

[oshima, 2015-05-05 16:45:01]

The CQ bit was checked by oshima@chromium.org

[commit-bot: I haz the power, 2015-05-05 16:45:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1119953002/300001

[commit-bot: I haz the power, 2015-05-05 17:23:11]

Committed patchset #7 (id:300001)

[commit-bot: I haz the power, 2015-05-05 17:24:13]

Patchset 7 (id:??) landed as
https://crrev.com/38dffadd1f16d7378a7c58b847fca47ac0ad7e17
Cr-Commit-Position: refs/heads/master@{#328348}