Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 11199003: Create a run_multipage_benchmarks entry point for all benchmarks. (Closed)

Created:
8 years, 2 months ago by tonyg
Modified:
8 years, 2 months ago
Reviewers:
dtu, nduca
CC:
chromium-reviews, pam+watch_chromium.org, dtu, hartmanng
Visibility:
Public.

Description

Create a run_multipage_benchmarks entry point for all benchmarks. Usage is: ./run_multipage_benchmarks [options] <benchmark> <page_set> Where <benchmark> is the name of the file containing the benchmarks to run. This patch doesn't handle benchmark discovery which will find all *_benchmark.py files and run all classes that subclass PageTest. BUG=None TEST=None Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162450

Patch Set 1 #

Total comments: 6

Patch Set 2 : Address dtu's comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+77 lines, -107 lines) Patch
M tools/chrome_remote_control/chrome_remote_control/multi_page_benchmark.py View 2 chunks +0 lines, -46 lines 0 comments Download
M tools/perf/perf_tools/first_paint_time_benchmark.py View 1 chunk +0 lines, -3 lines 0 comments Download
A tools/perf/perf_tools/multipage_benchmark_runner.py View 1 1 chunk +75 lines, -0 lines 0 comments Download
M tools/perf/perf_tools/scrolling_benchmark.py View 1 chunk +0 lines, -4 lines 0 comments Download
M tools/perf/perf_tools/skpicture_printer.py View 1 chunk +0 lines, -3 lines 0 comments Download
M tools/perf/perf_tools/texture_upload_benchmark.py View 2 chunks +0 lines, -4 lines 0 comments Download
D tools/perf/run_first_paint_time_benchmark View 1 chunk +0 lines, -11 lines 0 comments Download
A + tools/perf/run_multipage_benchmarks View 1 chunk +2 lines, -3 lines 0 comments Download
D tools/perf/run_scrolling_benchmark View 1 chunk +0 lines, -11 lines 0 comments Download
D tools/perf/run_skpicture_printer View 1 chunk +0 lines, -11 lines 0 comments Download
D tools/perf/run_texture_benchmark View 1 chunk +0 lines, -11 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
tonyg
Like we talked about, this is just a step towards automatic discovery to get the ...
8 years, 2 months ago (2012-10-16 23:12:58 UTC) #1
dtu
nice! cleaner than before. lgtm https://chromiumcodereview.appspot.com/11199003/diff/1/tools/perf/perf_tools/multipage_benchmark_runner.py File tools/perf/perf_tools/multipage_benchmark_runner.py (right): https://chromiumcodereview.appspot.com/11199003/diff/1/tools/perf/perf_tools/multipage_benchmark_runner.py#newcode46 tools/perf/perf_tools/multipage_benchmark_runner.py:46: sys.stderr.write('Available benchmarks:\n%s\n\n' % ',\n'.join( ...
8 years, 2 months ago (2012-10-16 23:53:43 UTC) #2
tonyg
8 years, 2 months ago (2012-10-17 00:13:44 UTC) #3
https://chromiumcodereview.appspot.com/11199003/diff/1/tools/perf/perf_tools/...
File tools/perf/perf_tools/multipage_benchmark_runner.py (right):

https://chromiumcodereview.appspot.com/11199003/diff/1/tools/perf/perf_tools/...
tools/perf/perf_tools/multipage_benchmark_runner.py:46:
sys.stderr.write('Available benchmarks:\n%s\n\n' % ',\n'.join(
On 2012/10/16 23:53:44, Dave Tu wrote:
> print >> sys.stderr, 'Available bench...'

Done.

https://chromiumcodereview.appspot.com/11199003/diff/1/tools/perf/perf_tools/...
tools/perf/perf_tools/multipage_benchmark_runner.py:60: if possible_browser ==
None:
On 2012/10/16 23:53:44, Dave Tu wrote:
> if not possible_browser:

Done.

https://chromiumcodereview.appspot.com/11199003/diff/1/tools/perf/perf_tools/...
tools/perf/perf_tools/multipage_benchmark_runner.py:70: # purpose of outputting
the perf results.
On 2012/10/16 23:53:44, Dave Tu wrote:
> Not sure about the validity of this assumption. What if you're comparing two
> builds?

It just changes the string that is printed in the results summary, so it doesn't
really hurt if this assumption breaks down. Anyway, this method was all just
copied from multi_page_benchmark.py, so it's not really the point of the patch.

Powered by Google App Engine
This is Rietveld 408576698