public/web/WebRemoteFrame.h - Issue 1119823003: Allow createLocalChild to specify previous sibling frame.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: public/web/WebRemoteFrame.h

Issue 1119823003: Allow createLocalChild to specify previous sibling frame. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Change appendChild to use insertAfter Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: public/web/WebRemoteFrame.h

diff --git a/public/web/WebRemoteFrame.h b/public/web/WebRemoteFrame.h

index 3d7d346f305bec807b127478818c1d12c459527f..9fe92e44d643cb2bc4710313a2bf7b06c4b702d8 100644

--- a/public/web/WebRemoteFrame.h

+++ b/public/web/WebRemoteFrame.h

@@ -17,7 +17,9 @@ class WebRemoteFrame : public WebFrame {

public:

BLINK_EXPORT static WebRemoteFrame* create(WebRemoteFrameClient*);

+ // TODO(alexmos): Remove once Chromium side is updated to take previous sibling.

virtual WebLocalFrame* createLocalChild(const WebString& name, WebSandboxFlags, WebFrameClient*) = 0;

+ virtual WebLocalFrame* createLocalChild(const WebString& name, WebSandboxFlags, WebFrameClient*, WebFrame*) = 0;

virtual WebRemoteFrame* createRemoteChild(const WebString& name, WebSandboxFlags, WebRemoteFrameClient*) = 0;

« Source/web/tests/WebFrameTest.cpp ('K') | « public/web/WebFrame.h ('k') | no next file » | no next file with comments »