Allow createLocalChild to specify previous sibling frame.

Source/web/tests/WebFrameTest.cpp

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 7289 matching lines @@
     EXPECT_TRUE(webFrameClient.messages.empty());
     ASSERT_EQ(2u, popupWebFrameClient.messages.size());
     EXPECT_TRUE(std::string::npos != popupWebFrameClient.messages[1].text.utf8().find("Blocked a frame"));
 
     // Manually reset to break WebViewHelpers' dependencies on the stack
     // allocated WebFrameClients.
     webViewHelper.reset();
     popupWebViewHelper.reset();
 }
 
+TEST_F(WebFrameTest, CreateLocalChildWithPreviousSibling)
+{
+    FrameTestHelpers::TestWebViewClient viewClient;
+    FrameTestHelpers::TestWebRemoteFrameClient remoteClient;
+    WebView* view = WebView::create(&viewClient);
+    view->setMainFrame(remoteClient.frame());
+    WebRemoteFrame* parent = view->mainFrame()->toWebRemoteFrame();
+
+    WebLocalFrame* secondFrame = parent->createLocalChild("", WebSandboxFlags::None, nullptr, nullptr);
+    WebLocalFrame* fourthFrame = parent->createLocalChild("", WebSandboxFlags::None, nullptr, secondFrame);
+    WebLocalFrame* thirdFrame = parent->createLocalChild("", WebSandboxFlags::None, nullptr, secondFrame);
+    WebLocalFrame* firstFrame = parent->createLocalChild("", WebSandboxFlags::None, nullptr, nullptr);
+
+    EXPECT_EQ(firstFrame, parent->firstChild());
+    EXPECT_EQ(nullptr, firstFrame->previousSibling());
+    EXPECT_EQ(secondFrame, firstFrame->nextSibling());
+
+    EXPECT_EQ(firstFrame, secondFrame->previousSibling());
+    EXPECT_EQ(thirdFrame, secondFrame->nextSibling());
+
+    EXPECT_EQ(secondFrame, thirdFrame->previousSibling());
+    EXPECT_EQ(fourthFrame, thirdFrame->nextSibling());
+
+    EXPECT_EQ(thirdFrame, fourthFrame->previousSibling());
+    EXPECT_EQ(nullptr, fourthFrame->nextSibling());
+    EXPECT_EQ(fourthFrame, parent->lastChild());
+
+    EXPECT_EQ(parent, firstFrame->parent());
+    EXPECT_EQ(parent, secondFrame->parent());
+    EXPECT_EQ(parent, thirdFrame->parent());
+    EXPECT_EQ(parent, fourthFrame->parent());

[dcheng, 2015/05/04 17:30:36]

I wonder if some version of nick's frame tree printer would be useful here.

[alexmos, 2015/05/04 21:38:54]

Yeah, that would be very handy. :)  Would probably also simplify consistency
checks for the swap tests.  I'll see if I can get to it some day.

+
+    view->close();
+}
+
 } // namespace blink