Issue 1119813002: Use the correct node when hit testing on an image map

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1119813002: Use the correct node when hit testing on an image map (Closed)

Created:
5 years, 7 months ago by rhogan

Modified:
5 years, 7 months ago

Reviewers:
pdr.

CC:
blink-reviews, blink-reviews-rendering, Dominik Röttsches, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, zoltan1

Base URL:
svn://svn.chromium.org/blink/trunk

Target Ref:
refs/heads/master

Project:
blink

Visibility:
Public.

More Reviews

Description

Use the correct node when hit testing on an image map This was a slip during https://codereview.chromium.org/1094133004 - I meant to use the imageElement's layout object, not the one associated with whatever node had been hit in the alt content. BUG=482214 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=194773

Patch Set 1 #

Created: 5 years, 7 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -2 lines)			Patch
A	LayoutTests/fast/replaced/image-map-alt-content-crash.html	View	1 chunk	+10 lines, -0 lines	0 comments	Download
A	LayoutTests/fast/replaced/image-map-alt-content-crash-expected.txt	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	Source/core/layout/HitTestResult.cpp	View	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119813002/1

5 years, 7 months ago (2015-04-30 20:03:35 UTC) #5

commit-bot: I haz the power

5 years, 7 months ago (2015-04-30 21:21:45 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=194773

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages