Linux: restore the option to build with system libvpx

Linux: restore the option to build with system libvpx

BUG=none
TEST=none
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=163000

[awong, 2012-10-18 23:26:15]

punting to scherkus since I'm not on media team anymore.

[scherkus (not reviewing), 2012-10-19 02:11:20]

hclam: can you take a look?

I haven't touched libvpx.gyp in a lonnnnngg time.

phajdan: do you happen to know when it was removed? I did a quick skim over the
revision log but didn't find any obvious commits.

[Alpha Left Google, 2012-10-19 02:20:04]

LGTM.

I removed it in the first place, libvpx was used by chromoting *only* originally
hence it didn't need to support system libvpx. With webrtc I can see there's a
reason for building Chromium with system libvpx.

[Paweł Hajdan Jr., 2012-10-19 16:21:49]

On 2012/10/19 02:20:04, Alpha wrote:
> LGTM.

Thanks!
 
> I removed it in the first place, libvpx was used by chromoting *only*
originally
> hence it didn't need to support system libvpx. With webrtc I can see there's a
> reason for building Chromium with system libvpx.

Curious - why chromoting being the only client in Chrome made you think option
for system libvpx is not needed, while adding webrtc changed that? Generally we
need those options regardless of how many places in Chrome use given library.
The point is that Linux distros do not want bundled libraries in software they
package.

[Alpha Left Google, 2012-10-19 18:26:11]

On 2012/10/19 16:21:49, Paweł Hajdan Jr. wrote:
> On 2012/10/19 02:20:04, Alpha wrote:
> > LGTM.
> 
> Thanks!
>  
> > I removed it in the first place, libvpx was used by chromoting *only*
> originally
> > hence it didn't need to support system libvpx. With webrtc I can see there's
a
> > reason for building Chromium with system libvpx.
> 
> Curious - why chromoting being the only client in Chrome made you think option
> for system libvpx is not needed, while adding webrtc changed that? Generally
we
> need those options regardless of how many places in Chrome use given library.
> The point is that Linux distros do not want bundled libraries in software they
> package.

I *believe* we had a plan to remove chromoting client from Chrome's static lib,
that means libvpx shouldn't be linked. However webrtc is a core Chrome feature
that depends on libvpx.