runtime/vm/flow_graph_compiler_x64.cc - Issue 11198072: Inline load and store index on Float32Arrays.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/flow_graph_compiler_x64.cc

Issue 11198072: Inline load and store index on Float32Arrays. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Codereview fixes. Created 8 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/flow_graph_compiler_x64.cc

diff --git a/runtime/vm/flow_graph_compiler_x64.cc b/runtime/vm/flow_graph_compiler_x64.cc

index 6c7629018e96d113ae7c5c4bf5cf21ca550c1660..4f25db4d4b5fd1261d322c2ff711454001043e21 100644

--- a/runtime/vm/flow_graph_compiler_x64.cc

+++ b/runtime/vm/flow_graph_compiler_x64.cc

@@ -35,6 +35,8 @@ FieldAddress FlowGraphCompiler::ElementAddressForRegIndex(intptr_t cid,

case kArrayCid:

case kImmutableArrayCid:

return FieldAddress(array, index, TIMES_4, sizeof(RawArray));

+ case kFloat32ArrayCid:

+ return FieldAddress(array, index, TIMES_2, Float32Array::data_offset());

case kFloat64ArrayCid:

return FieldAddress(array, index, TIMES_4, Float64Array::data_offset());

default: