Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2423)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/resources/options/browser_options.html

Issue 11198065: Add fourth batch of controlled setting indicators (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 8 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/policy/policy_prefs_browsertest.cc ('k') | chrome/browser/resources/options/browser_options.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/options/browser_options.html
diff --git a/chrome/browser/resources/options/browser_options.html b/chrome/browser/resources/options/browser_options.html
index 68aae2f04368b3141fec3539f17b6d1c2a440881..783c2450704864b35fdc36f493b3eb6e76957c0c 100644
--- a/chrome/browser/resources/options/browser_options.html
+++ b/chrome/browser/resources/options/browser_options.html
@@ -46,11 +46,20 @@
<button id="themes-reset" i18n-content="themesReset"></button>
</if>
</div>
- <div class="checkbox" guest-visibility="disabled"><label>
- <input id="show-home-button" type="checkbox"
- pref="browser.show_home_button" metric="Options_Homepage_HomeButton">
- <span i18n-content="homePageShowHomeButton"></span>
- </label></div>
+ <div class="checkbox" guest-visibility="disabled">
+ <span class="controlled-setting-with-label">
+ <input id="show-home-button" type="checkbox"
+ pref="browser.show_home_button"
+ metric="Options_Homepage_HomeButton">
+ <span>
James Hawkins 2012/10/18 20:51:51 What is this span for?
bartfab (slow) 2012/10/18 21:13:33 All settings I modified got such a <span>. It is a
+ <label for="show-home-button" i18n-content="homePageShowHomeButton">
+ </label>
+ <span class="controlled-setting-indicator"
+ pref="browser.show_home_button">
+ </span>
+ </span>
+ </span>
+ </div>
<div id="change-home-page-section" hidden>
<div id="change-home-page-section-container" guest-visibility="disabled">
<span id="home-page-ntp" class="home-page-label"
« no previous file with comments | « chrome/browser/policy/policy_prefs_browsertest.cc ('k') | chrome/browser/resources/options/browser_options.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698