Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(42)

Issue 1119803007: [chrome/browser/chromeos] Replace MessageLoopProxy usage with ThreadTaskRunnerHandle (Closed)

Created:
5 years, 7 months ago by Pranay
Modified:
5 years, 7 months ago
Reviewers:
oshima, Daniel Erat
CC:
chromium-reviews, extensions-reviews_chromium.org, derat+watch_chromium.org, tzik, nhiroki, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, stevenjb+watch_chromium.org, kinuko+fileapi, davemoore+watch_chromium.org, anujsharma
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Replace MessageLoopProxy usage with ThreadTaskRunnerHandle in chrome/browser/chromeos module. MessageLoopProxy is deprecated. This basically does a search and replace of: MessageLoopProxy::current() -> ThreadTaskRunnerHandle::Get(). MessageLoopProxy -> SingleThreadTaskRunner BUG=391045 Committed: https://crrev.com/25ec7c75a4aefac618be497595b4768c38cf7517 Cr-Commit-Position: refs/heads/master@{#328533}

Patch Set 1 #

Patch Set 2 : Fixed nit #

Total comments: 4

Patch Set 3 : Fixed Review Comments & removed fake_provided_file_system.cc due to cancelable_task_tracker dependeā€¦ #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -11 lines) Patch
M chrome/browser/chromeos/app_mode/kiosk_app_update_service_browsertest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/file_system_provider/fileapi/buffering_file_stream_reader_unittest.cc View 1 2 3 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/chromeos/power/extension_event_observer.cc View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 21 (7 generated)
Pranay
PTAL Thanks
5 years, 7 months ago (2015-05-05 06:16:35 UTC) #2
Daniel Erat
https://codereview.chromium.org/1119803007/diff/20001/chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc File chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc (right): https://codereview.chromium.org/1119803007/diff/20001/chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc#newcode7 chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc:7: #include "base/single_thread_task_runner.h" why is this included? it doesn't look ...
5 years, 7 months ago (2015-05-05 15:17:04 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119803007/20001
5 years, 7 months ago (2015-05-05 15:18:23 UTC) #6
oshima
What dan said.
5 years, 7 months ago (2015-05-05 15:29:21 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_chromeos_rel/builds/34178)
5 years, 7 months ago (2015-05-05 15:41:52 UTC) #9
Pranay
Hi, Thanks for the review. Updated patch & removed fake_provided_file_system.cc from the patch PTAL :) ...
5 years, 7 months ago (2015-05-06 05:47:45 UTC) #10
Pranay
https://codereview.chromium.org/1119803007/diff/20001/chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc File chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc (right): https://codereview.chromium.org/1119803007/diff/20001/chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc#newcode7 chrome/browser/chromeos/file_system_provider/fake_provided_file_system.cc:7: #include "base/single_thread_task_runner.h" File removed from patch due to cancelable_task ...
5 years, 7 months ago (2015-05-06 05:48:50 UTC) #11
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119803007/40001
5 years, 7 months ago (2015-05-06 12:46:58 UTC) #13
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-05-06 13:19:37 UTC) #15
Daniel Erat
lgtm
5 years, 7 months ago (2015-05-06 13:58:49 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119803007/40001
5 years, 7 months ago (2015-05-06 14:50:59 UTC) #18
Pranay
Thanks :)
5 years, 7 months ago (2015-05-06 14:51:01 UTC) #19
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 7 months ago (2015-05-06 14:55:05 UTC) #20
commit-bot: I haz the power
5 years, 7 months ago (2015-05-06 14:56:00 UTC) #21
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/25ec7c75a4aefac618be497595b4768c38cf7517
Cr-Commit-Position: refs/heads/master@{#328533}

Powered by Google App Engine
This is Rietveld 408576698