Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(270)

Issue 1119803006: Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider (Closed)

Created:
5 years, 7 months ago by Dan Beam
Modified:
5 years, 7 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Paweł Hajdan Jr.
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider (patchset #3 id:40001 of https://codereview.chromium.org/1114383003/) Reason for revert: Final stop on the revert train! net_unittests on iOS Simulator (dbg) (iPhone 5 ios 8.1) should be fixed after this? https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_(dbg) Here's a log of the break: https://build.chromium.org/p/chromium.mac/builders/iOS_Simulator_%28dbg%29/builds/26378/steps/net_unittests%20%28iPhone%205%20iOS%208.1%29/logs/crash%20report%20%282015-05-04-164655%29 Original issue's description: > Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider > so that all provider subclasses can have their state verified. > > Committed: https://crrev.com/bce10d97d6fc5233071427cf622aaad7abde9e19 > Cr-Commit-Position: refs/heads/master@{#328154} TBR=rtenneti@chromium.org,sergeyu@chromium.org,rch@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true Committed: https://crrev.com/861e7ec31c1917c3c7447356be2a8a26cf8588b3 Cr-Commit-Position: refs/heads/master@{#328271}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+236 lines, -267 lines) Patch
M jingle/glue/chrome_async_socket_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M net/ftp/ftp_network_transaction_unittest.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M net/quic/quic_http_stream_test.cc View 1 chunk +1 line, -2 lines 0 comments Download
M net/quic/quic_network_transaction_unittest.cc View 2 chunks +8 lines, -8 lines 0 comments Download
M net/quic/quic_stream_factory_test.cc View 26 chunks +80 lines, -80 lines 0 comments Download
M net/socket/sequenced_socket_data_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M net/socket/socket_test_util.h View 4 chunks +12 lines, -12 lines 0 comments Download
M net/socket/socket_test_util.cc View 10 chunks +18 lines, -34 lines 0 comments Download
M net/spdy/spdy_http_stream_unittest.cc View 7 chunks +14 lines, -14 lines 0 comments Download
M net/spdy/spdy_network_transaction_unittest.cc View 15 chunks +76 lines, -62 lines 0 comments Download
M net/spdy/spdy_session_unittest.cc View 12 chunks +19 lines, -19 lines 0 comments Download
M net/spdy/spdy_stream_unittest.cc View 6 chunks +6 lines, -6 lines 0 comments Download
M remoting/base/buffered_socket_writer_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download
M remoting/signaling/xmpp_signal_strategy_unittest.cc View 1 chunk +0 lines, -8 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Dan Beam
Created Revert of Add AllReadDataConsumed and AllWriteDataConsumed methods to SocketDataProvider
5 years, 7 months ago (2015-05-05 03:54:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119803006/1
5 years, 7 months ago (2015-05-05 03:54:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-05 03:56:26 UTC) #3
commit-bot: I haz the power
5 years, 7 months ago (2015-05-05 03:57:15 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/861e7ec31c1917c3c7447356be2a8a26cf8588b3
Cr-Commit-Position: refs/heads/master@{#328271}

Powered by Google App Engine
This is Rietveld 408576698