Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 11198030: Android WebView: make sure libwebview target isn't mangled. (Closed)

Created:
8 years, 2 months ago by Torne
Modified:
8 years, 2 months ago
Reviewers:
benm (inactive)
CC:
chromium-reviews, android-webview-reviews_chromium.org
Visibility:
Public.

Description

Android WebView: make sure libwebview target isn't mangled. The android gyp backend has been updated to introduce an "android_unmangled_name" target option, which allows the backend to skip mangling the name of designated targets. Turn this on for libwebview in order that it's generated as libwebview.so instead of lib_android_webview_libwebview_gyp.so which was rather confusing. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=162410

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -0 lines) Patch
M android_webview/android_webview.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Torne
I've submitted the gyp change for this and rolled it into Chromium's DEPS, so now ...
8 years, 2 months ago (2012-10-17 14:04:53 UTC) #1
benm (inactive)
8 years, 2 months ago (2012-10-17 14:45:46 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698