Allow building Official Chrome builds in Debug on ARM by avoiding overcommitting registers.

breakpad/breakpad.gyp

 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 {
   'includes': [
     'breakpad_sender.gypi',
     'breakpad_handler.gypi',
   ],
   'conditions': [
@@ skipping 514 matching lines @@
             'src/common/memory.h',
             'src/common/string_conversion.cc',
             'src/common/string_conversion.h',
           ],
 
           'conditions': [
             # Android NDK toolchain doesn't support -mimplicit-it=always
             ['target_arch=="arm" and OS!="android"', {
               'cflags': ['-Wa,-mimplicit-it=always'],
             }],
+            ['target_arch=="arm"', {
+              # Avoid running out of registers.

[digit1, 2012/10/17 08:23:59]

Can you put that in a chromeos-specific condition, and explain the issue in more
details (e.g. "Avoid compile issues with the linux_syscall_support.h sys_clone()
inline assembly").

This would allow you to remove this more easily in the future when/if the
problem is fixed in a future version of LSS. (Yes, I really hate exotic compiler
flags that creep in build files without a good explanation :-))

[Ami GONE FROM CHROMIUM, 2012/10/17 08:48:32]

Done.

+              'cflags': ['-marm'],
+            }],
             ['OS=="android"', {
               'include_dirs': [
                 'src/common/android/include',
               ],
               'direct_dependent_settings': {
                 'include_dirs': [
                   'src/common/android/include',
                 ],
               },
               'sources': [
@@ skipping 304 matching lines @@
             'include_dirs': [
               '<(DEPTH)/third_party/GTM',
               '<(DEPTH)/third_party/GTM/Foundation',
             ],
           },
         },
       ],
     }],
   ],
 }