[Mac] Tweak crash logging for -sendEvent: crash.

chrome/browser/chrome_browser_application_mac.mm

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "chrome/browser/chrome_browser_application_mac.h"
 
 #import "base/auto_reset.h"
 #import "base/logging.h"
 #include "base/mac/crash_logging.h"
 #import "base/mac/scoped_nsexception_enabler.h"
@@ skipping 417 matching lines @@
 
 - (void)setHandlingSendEvent:(BOOL)handlingSendEvent {
   handlingSendEvent_ = handlingSendEvent;
 }
 
 - (void)sendEvent:(NSEvent*)event {
   // TODO(shess): Squirrel away some info to direct debugging.
   // Current hypothesis is that it's a keyboard accelerator.
   // http://crbug.com/154483
   static NSString* const kSendEventKey = @"sendevent";
-  base::mac::ScopedCrashKey key(kSendEventKey, [event description]);
+  // For NSEventType 28, recursive -description causes a crash.
+  // Not much to be done, that type is undocumented.
+  NSString* value = [event type] == 28 ? @"type=28" : [event description];
+  base::mac::ScopedCrashKey key(kSendEventKey, value);

[Scott Hess - ex-Googler, 2012/10/16 21:56:32]

Why not haz magic constant?  Because I couldn't think of a name. 
kUndocumentedCrashingType?  I don't know.

[Nico, 2012/10/16 22:23:30]

kTwentyEight, duh.

 
   base::mac::ScopedSendingEvent sendingEventScoper;
   for (id<CrApplicationEventHookProtocol> handler in eventHooks_.get()) {
     [handler hookForEvent:event];
   }
   [super sendEvent:event];
 }
 
 // NSExceptions which are caught by the event loop are logged here.
 // NSException uses setjmp/longjmp, which can be very bad for C++, so
@@ skipping 132 matching lines @@
   std::vector<NSWindow*>::iterator window_iterator =
       std::find(previousKeyWindows_.begin(),
                 previousKeyWindows_.end(),
                 window);
   if (window_iterator != previousKeyWindows_.end()) {
     previousKeyWindows_.erase(window_iterator);
   }
 }
 
 @end