Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issue 1119783002: vs2015: fix narrowing warnings in sandbox/win/ (Closed)

Created:
5 years, 7 months ago by scottmg
Modified:
5 years, 7 months ago
Reviewers:
cpu_(ooo_6.6-7.5)
CC:
chromium-reviews, wfh+watch_chromium.org, rickyz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@2015-printing-emf
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

vs2015: fix narrowing warnings in sandbox/win/ d:\src\cr2\src\sandbox\win\src\broker_services.cc(282): warning C4311: 'reinterpret_cast': pointer truncation from 'LPOVERLAPPED' to 'DWORD' d:\src\cr2\src\sandbox\win\src\broker_services.cc(282): warning C4302: 'reinterpret_cast': truncation from 'LPOVERLAPPED' to 'DWORD' d:\src\cr2\src\sandbox\win\src\broker_services.cc(312): warning C4311: 'reinterpret_cast': pointer truncation from 'LPOVERLAPPED' to 'DWORD' d:\src\cr2\src\sandbox\win\src\broker_services.cc(312): warning C4302: 'reinterpret_cast': truncation from 'LPOVERLAPPED' to 'DWORD' d:\src\cr2\src\sandbox\win\src\broker_services.cc(546): warning C4312: 'reinterpret_cast': conversion from 'DWORD' to 'LPOVERLAPPED' of greater size d:\src\cr2\src\sandbox\win\src\eat_resolver.cc(51): warning C4302: 'reinterpret_cast': truncation from 'void *' to 'DWORD' d:\src\cr2\src\sandbox\win\src\eat_resolver.cc(52): warning C4302: 'reinterpret_cast': truncation from 'const void *' to 'DWORD' R=cpu@chromium.org BUG=440500 Committed: https://crrev.com/359cb535d023f8c83f7b6a796bc43a30f4594ad7 Cr-Commit-Position: refs/heads/master@{#327868}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -11 lines) Patch
M sandbox/win/src/broker_services.cc View 3 chunks +7 lines, -5 lines 0 comments Download
M sandbox/win/src/eat_resolver.cc View 1 chunk +2 lines, -6 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
scottmg
I don't think these change behaviour, but please give them extra scrutiny given their location.
5 years, 7 months ago (2015-04-30 17:23:57 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119783002/1
5 years, 7 months ago (2015-04-30 17:24:54 UTC) #3
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 7 months ago (2015-04-30 19:20:36 UTC) #5
cpu_(ooo_6.6-7.5)
lgtm
5 years, 7 months ago (2015-05-01 02:14:08 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119783002/1
5 years, 7 months ago (2015-05-01 02:14:30 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-05-01 02:50:12 UTC) #9
commit-bot: I haz the power
5 years, 7 months ago (2015-05-01 02:51:41 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/359cb535d023f8c83f7b6a796bc43a30f4594ad7
Cr-Commit-Position: refs/heads/master@{#327868}

Powered by Google App Engine
This is Rietveld 408576698