Animations: Port LinkHighlight to use compositor timelines.

Source/web/WebViewImpl.h

 /*
  * Copyright (C) 2010 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 19 matching lines @@
 
 #ifndef WebViewImpl_h
 #define WebViewImpl_h
 
 #include "core/page/ContextMenuProvider.h"
 #include "core/page/EventWithHitTestResults.h"
 #include "platform/geometry/IntPoint.h"
 #include "platform/geometry/IntRect.h"
 #include "platform/graphics/GraphicsLayer.h"
 #include "platform/heap/Handle.h"
+#include "public/platform/WebCompositorAnimationTimeline.h"
 #include "public/platform/WebDisplayMode.h"
 #include "public/platform/WebFloatSize.h"
 #include "public/platform/WebGestureCurveTarget.h"
 #include "public/platform/WebLayer.h"
 #include "public/platform/WebPoint.h"
 #include "public/platform/WebRect.h"
 #include "public/platform/WebSize.h"
 #include "public/platform/WebString.h"
 #include "public/platform/WebVector.h"
 #include "public/web/WebInputEvent.h"
@@ skipping 20 matching lines @@
 class Frame;
 class FullscreenController;
 class InspectorOverlay;
 class InspectorOverlayImpl;
 class LinkHighlight;
 class PageScaleConstraintsSet;
 class DeprecatedPaintLayerCompositor;
 class TopControls;
 class UserGestureToken;
 class WebActiveGestureAnimation;
-class WebCompositorAnimationTimeline;
 class WebDevToolsAgentImpl;
 class WebElement;
 class WebLayerTreeView;
 class WebLocalFrameImpl;
 class WebImage;
 class WebPagePopupImpl;
 class WebPlugin;
 class WebSelection;
 class WebSettingsImpl;
 
@@ skipping 345 matching lines @@
 
     GraphicsLayer* rootGraphicsLayer();
     void setRootGraphicsLayer(GraphicsLayer*);
     void scheduleCompositingLayerSync();
     GraphicsLayerFactory* graphicsLayerFactory() const;
     DeprecatedPaintLayerCompositor* compositor() const;
     void registerForAnimations(WebLayer*);
     void scheduleAnimation();
     void attachCompositorAnimationTimeline(WebCompositorAnimationTimeline*);
     void detachCompositorAnimationTimeline(WebCompositorAnimationTimeline*);
+    WebCompositorAnimationTimeline* linkHighlightsTimeline() const { return m_linkHighlightsTimeline.get(); }
 
     virtual void setVisibilityState(WebPageVisibilityState, bool) override;
 
     bool hasOpenedPopup() const { return m_pagePopup; }
 
     // Returns true if the event leads to scrolling.
     static bool mapKeyCodeForScroll(
         int keyCode,
         ScrollDirectionPhysical*,
         ScrollGranularity*);
@@ skipping 276 matching lines @@
     bool m_recreatingGraphicsContext;
     static const WebInputEvent* m_currentInputEvent;
 
     MediaKeysClientImpl m_mediaKeysClientImpl;
     OwnPtr<WebActiveGestureAnimation> m_gestureAnimation;
     WebPoint m_positionOnFlingStart;
     WebPoint m_globalPositionOnFlingStart;
     int m_flingModifier;
     bool m_flingSourceDevice;
     Vector<OwnPtr<LinkHighlight>> m_linkHighlights;
+    OwnPtr<WebCompositorAnimationTimeline> m_linkHighlightsTimeline;

[chrishtr, 2015/07/13 21:20:53]

Why do you need a timeline specific to link highlights?

[loyso (OOO), 2015/07/14 00:59:04]

Timeline is a group of players, basically. Here we isolate highlight animations
in a special group. (Note that we will rename cc::AnimationPlayer to Animation
and cc::Animation to cc::KeyframeEffect, like here
https://codereview.chromium.org/1113173003/)

In general, highlights use animation system in superficial way. And we want
animation system to be unified with blink to get rid of redundancies.

[chrishtr, 2015/07/14 18:34:00]

Is it actually possible to animate a link highlight?

LinkHighlight is an unfortunate source of one-off complexity that we should
reduce, not increase, which is why we should try to avoid the complexities in
this CL if possible.

[loyso (OOO), 2015/07/15 02:04:36]

Yes, that's an opacity animation if you touch a hyper link on android (What's
funny is that it didn't support --disable-threaded-animation mode).
So, I don't understand the question (given that you started the discussion here:
https://groups.google.com/a/chromium.org/d/msg/paint-dev/b6hEgxo6AbY/gH8snoYW...
)
1) We will delete the old layer-intrusive animation system eventually. All the
conditional branches will be gone.
2) Adding animations directly to layers was a source of highly-coupled code in
chrome compositor. So we needed some external entity to add animations. It's an
AnimationPlayer now.
3) CC animation system is "the least common denominator" for all sub-systems.
And we need to keep LinkHighlights in a working shape.
4) I had the idea to have hidden timeline inside the AnimationHost to handle all
the "orphaned" AnimationPlayers. But this would introduce an unstructured soup
(no grouping == no isolation), which would be hard to debug. So I decided to
keep the group explicit. Moreover, probably we will move some properties (?)
from individual animations into AnimationTimeline.

[chrishtr, 2015/07/15 14:25:14]

It looks like each Document has a timeline already. Can you just re-use the
timeline for the containing document for link highlight animations?

[loyso (OOO), 2015/07/21 01:19:07]

Acknowledged.

     OwnPtrWillBePersistent<FullscreenController> m_fullscreenController;
 
     bool m_showFPSCounter;
     bool m_continuousPaintingEnabled;
     WebColor m_baseBackgroundColor;
     WebColor m_backgroundColorOverride;
     float m_zoomFactorOverride;
 
     bool m_userGestureObserved;
     WebDisplayMode m_displayMode;
 
     RefPtr<EventListener> m_popupMouseWheelEventListener;
 };
 
 DEFINE_TYPE_CASTS(WebViewImpl, WebWidget, widget, widget->isWebView(), widget.isWebView());
 // We have no ways to check if the specified WebView is an instance of
 // WebViewImpl because WebViewImpl is the only implementation of WebView.
 DEFINE_TYPE_CASTS(WebViewImpl, WebView, webView, true, true);
 
 } // namespace blink
 
 #endif