Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(22)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1119763002: Fix html_viewer Windows build after r327559 (Closed)

Created:
5 years, 7 months ago by jam
Modified:
5 years, 7 months ago
Reviewers:
sky
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix html_viewer Windows build after r327559 Committed: https://crrev.com/a34ed2181eb8d7db3fc35f9bead91bbea87e255c Cr-Commit-Position: refs/heads/master@{#327763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M mojo/runner/native_application_support.h View 1 chunk +0 lines, -4 lines 0 comments Download
M mojo/shell/native_runner.h View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
jam
5 years, 7 months ago (2015-04-30 15:36:22 UTC) #2
sky
LGTM
5 years, 7 months ago (2015-04-30 15:43:18 UTC) #3
jam
(I'm trying to figure out why it's not building on the main waterfall GN builders ...
5 years, 7 months ago (2015-04-30 15:43:24 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1119763002/1
5 years, 7 months ago (2015-04-30 19:22:27 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 7 months ago (2015-04-30 19:29:49 UTC) #7
commit-bot: I haz the power
5 years, 7 months ago (2015-04-30 19:30:50 UTC) #8
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/a34ed2181eb8d7db3fc35f9bead91bbea87e255c
Cr-Commit-Position: refs/heads/master@{#327763}

Powered by Google App Engine
This is Rietveld 408576698