Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(704)

Unified Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 1119723002: SVG animate should respect attribute 'restart=never'. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Rebased and aligned with code review Created 5 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/animation/SVGSMILElement.cpp
diff --git a/Source/core/svg/animation/SVGSMILElement.cpp b/Source/core/svg/animation/SVGSMILElement.cpp
index 719cd493840b94a7801b10273ec43467b5cb4cea..e76a8249361fdb057e6ec28285e5814b038d1e35 100644
--- a/Source/core/svg/animation/SVGSMILElement.cpp
+++ b/Source/core/svg/animation/SVGSMILElement.cpp
@@ -943,9 +943,9 @@ SMILTime SVGSMILElement::nextProgressTime() const
void SVGSMILElement::beginListChanged(SMILTime eventTime)
{
- if (m_isWaitingForFirstInterval)
+ if (m_isWaitingForFirstInterval) {
resolveFirstInterval();
- else {
+ } else if (this->restart() != RestartNever) {
fs 2015/05/08 10:28:31 I still think this should be checked later, but I'
SMILTime newBegin = findInstanceTime(Begin, eventTime, true);
if (newBegin.isFinite() && (m_interval.end <= eventTime || newBegin < m_interval.begin)) {
// Begin time changed, re-resolve the interval.

Powered by Google App Engine
This is Rietveld 408576698