Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: Source/core/svg/animation/SVGSMILElement.cpp

Issue 1119723002: SVG animate should respect attribute 'restart=never'. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Removed unwanted lines Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/svg/animation/SVGSMILElement.cpp
diff --git a/Source/core/svg/animation/SVGSMILElement.cpp b/Source/core/svg/animation/SVGSMILElement.cpp
index 719cd493840b94a7801b10273ec43467b5cb4cea..10cae7b908794396b6ddcbde321f87b5a49a0815 100644
--- a/Source/core/svg/animation/SVGSMILElement.cpp
+++ b/Source/core/svg/animation/SVGSMILElement.cpp
@@ -1130,6 +1130,11 @@ bool SVGSMILElement::progress(SMILTime elapsed, SVGSMILElement* resultElement, b
return false;
}
+ if (!m_isWaitingForFirstInterval && m_activeState != Active && this->restart() == RestartNever) {
+ m_nextProgressTime = SMILTime::unresolved();
fs 2015/04/30 13:24:43 This seems a bit "early" to handle this? Not entir
Shanmuga Pandi 2015/04/30 13:42:57 Basically, I am trying to ignore the restart of an
fs 2015/04/30 13:53:42 Yes, I got that bit. =)
Shanmuga Pandi 2015/04/30 14:03:00 Sorry. Could you give some live example or jsfiddl
fs 2015/04/30 14:05:07 I think your testcase would should exactly that. I
+ return false;
+ }
+
if (elapsed < m_interval.begin) {
ASSERT(m_activeState != Active);
bool isFrozen = (m_activeState == Frozen);

Powered by Google App Engine
This is Rietveld 408576698