LayoutTests/svg/animations/animate-restart-never.html - Issue 1119723002: SVG animate should respect attribute 'restart=never'.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/svg/animations/animate-restart-never.html

Issue 1119723002: SVG animate should respect attribute 'restart=never'. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Rebased and aligned with code review Created 5 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script>

	3 if (window.testRunner)

	4 testRunner.waitUntilDone();

	5

	6 function click(x,y) {

	7 if (window.eventSender) {

	8 eventSender.mouseMoveTo(x, y);

	9 eventSender.mouseDown();

	10 eventSender.mouseUp();

	11 }

	12 }

	13

	14 function animationEnded() {

	15 click(50,50);

	16 if (window.testRunner) {

	17 testRunner.displayAsyncThen(function() {

	18 testRunner.notifyDone();

	19 });

	20 }

	21 }

	22 </script>

	23 <svg>

	24 <rect id="rect" width="100px" height="100px" fill="red">

	25 <animate

	26 begin="0s; rect.click"

	27 dur="0.05s"
	fs 2015/05/08 10:28:31 Please verify that this test fails reliably (in th Please verify that this test fails reliably (in the test-runner) without the fix. (There still appear to be a risk of timer vs. frame race here.) Shanmuga Pandi 2015/05/08 11:30:56 I have verified it , with out this fix, the test c Show quoted text On 2015/05/08 10:28:31, fs wrote: > Please verify that this test fails reliably (in the test-runner) without the > fix. (There still appear to be a risk of timer vs. frame race here.) I have verified it , with out this fix, the test case fails. Ran the test 100 times (Getting intermediate color between red and green) If we get any color other than green as output, then test will fail. Also I don't mind to increase the "dur" little bit more (may be 0.09s)
	28 attributeName="fill"

	29 from="red" to="green"

	30 fill="freeze"

	31 restart="never"

	32 onend="animationEnded()"/>

	33 </rect>

	34 </svg>

OLD	NEW

« no previous file with comments | « no previous file | LayoutTests/svg/animations/animate-restart-never-expected.html » ('j') | Source/core/svg/animation/SVGSMILElement.cpp » ('J')